public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Leonid Froenchenko <lfroen@galileo.co.il>,
	Jarod Wilson <jarod@wilsonet.com>
Subject: [PATCH] staging/media/lirc: fix some lirc_bt829.c sparse warnings
Date: Mon, 11 Jun 2012 18:28:34 -0700	[thread overview]
Message-ID: <4FD69B42.4070709@xenotime.net> (raw)

From: Randy Dunlap <rdunlap@xenotime.net>

Fix some sparse warnings in lirc_bt829.c:

drivers/staging/media/lirc/lirc_bt829.c:174:22: warning: non-ANSI function declaration of function 'poll_main'
drivers/staging/media/lirc/lirc_bt829.c:161:29: warning: Using plain integer as NULL pointer
drivers/staging/media/lirc/lirc_bt829.c:134:35: warning: Using plain integer as NULL pointer

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Leonid Froenchenko <lfroen@galileo.co.il>
Cc: Jarod Wilson <jarod@wilsonet.com>
---
 drivers/staging/media/lirc/lirc_bt829.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- lnx-35-rc2.orig/drivers/staging/media/lirc/lirc_bt829.c
+++ lnx-35-rc2/drivers/staging/media/lirc/lirc_bt829.c
@@ -131,7 +131,7 @@ int init_module(void)
 	atir_driver.minor       = -1;
 	atir_driver.code_length = 8;
 	atir_driver.sample_rate = 10;
-	atir_driver.data        = 0;
+	atir_driver.data        = NULL;
 	atir_driver.add_to_buf  = atir_add_to_buf;
 	atir_driver.set_use_inc = atir_set_use_inc;
 	atir_driver.set_use_dec = atir_set_use_dec;
@@ -158,7 +158,7 @@ void cleanup_module(void)
 static int atir_init_start(void)
 {
 	pci_addr_lin = ioremap(pci_addr_phys + DATA_PCI_OFF, 0x400);
-	if (pci_addr_lin == 0) {
+	if (pci_addr_lin == NULL) {
 		printk(KERN_INFO DRIVER_NAME ": pci mem must be mapped\n");
 		return 0;
 	}
@@ -171,7 +171,7 @@ static void cycle_delay(int cycle)
 }
 
 
-static int poll_main()
+static int poll_main(void)
 {
 	unsigned char status_high, status_low;
 

                 reply	other threads:[~2012-06-12  1:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD69B42.4070709@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=jarod@wilsonet.com \
    --cc=lfroen@galileo.co.il \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox