public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paul Bolle <pebolle@tiscali.nl>, <linux-m68k@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k: remove six unused headers
Date: Tue, 12 Jun 2012 16:06:33 +1000	[thread overview]
Message-ID: <4FD6DC69.2090008@snapgear.com> (raw)
In-Reply-To: <CAMuHMdXisLvXAPbbkuYsYH2UZ_DJSyEhKZOL6_4qwuwLzFcEoQ@mail.gmail.com>

Hi Geert,

On 10/06/12 18:40, Geert Uytterhoeven wrote:
> On Fri, Jun 8, 2012 at 8:26 AM, Greg Ungerer<gerg@snapgear.com>  wrote:
>> On 07/06/12 18:57, Paul Bolle wrote:
>>> There are six entirely unused headers in arch/m68k/include/asm. Nothing
>>> includes these headers. And a few tests found no hits for the things
>>> they provide (which makes sense).
>>>
>>> MC68332.h, mac_mouse.h, mcfmbus.h, and mcfne.h are all unused since at
>>> least v2.6.12-rc2 (I didn't bother looking further back than that).
>>
>>
>> Although mcfne.h has been unused for a while I am working on some patches
>> that do use it. No problem for the others.
>
> If I'm not mistaken, that should become mcf8390.h, as "NE2000" means
> "NE2000-compatible 8390-based Ethernet"? Cfr. the mac8390 and zorro8390
> discussions in the previous millennium.

I guess I missed those :-(
I think I see from the code for those under ~/drivers/net/ethernet/8390/
what this may have been about though.

Interestingly one of the ColdFire platforms (the Arnewsh 5206 board)
really did have an ISA NE2000 card fitted to it. Most of the follow
ons that where similar use a Davicom/9000.

I'll modify my work a little to follow the other examples.

Thanks
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  reply	other threads:[~2012-06-12  6:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07  8:57 [PATCH] m68k: remove six unused headers Paul Bolle
2012-06-08  6:26 ` Greg Ungerer
2012-06-10  8:40   ` Geert Uytterhoeven
2012-06-12  6:06     ` Greg Ungerer [this message]
2012-06-12  7:24       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD6DC69.2090008@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox