From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] pinctrl: nomadik: fix up typo
Date: Tue, 12 Jun 2012 12:08:38 +0100 [thread overview]
Message-ID: <4FD72336.9040803@linaro.org> (raw)
In-Reply-To: <1339498592-1435-1-git-send-email-linus.walleij@stericsson.com>
On 12/06/12 11:56, Linus Walleij wrote:
> Commit a60b57eddaa8af6c02cf7bbeb58ebf82881f08ac
> "drivers/gpio: gpio-nomadik: Add support for irqdomains"
> changed GPIO offset calculations to have this form:
> (gpio % NMK_GPIO_PER_CHIP) except in this one place for
> setting sleep mode, where the conversion was all wrong, and
> instead mod:ing the GPIO with the IRQ base which does not
> make any sense.
>
> So fix this up so we can use sleepmode.
>
> Cc: Lee Jones<lee.jones@linaro.org>
> Signed-off-by: Linus Walleij<linus.walleij@stericsson.com>
Makes sense.
Reviewed-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2012-06-12 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 10:56 [PATCH] pinctrl: nomadik: fix up typo Linus Walleij
2012-06-12 11:08 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD72336.9040803@linaro.org \
--to=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox