From: "H. Peter Anvin" <hpa@zytor.com>
To: Kent Yoder <shpedoikal@gmail.com>
Cc: "Zhang, Xiaoyan" <xiaoyan.zhang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"debora@linux.vnet.ibm.com" <debora@linux.vnet.ibm.com>,
"srajiv@linux.vnet.ibm.com" <srajiv@linux.vnet.ibm.com>,
"m.selhorst@sirrix.com" <m.selhorst@sirrix.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"james.l.morris@oracle.com" <james.l.morris@oracle.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"Cihula, Joseph" <joseph.cihula@intel.com>,
"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [PATCH 1/2] driver: add PPI support in tpm driver
Date: Tue, 12 Jun 2012 12:00:38 -0700 [thread overview]
Message-ID: <4FD791D6.5050503@zytor.com> (raw)
In-Reply-To: <CAM0nabHV6CepQyXeVZiv2XT9WHPgMy=prdK-8fNgyrCZ4v6dSg@mail.gmail.com>
On 06/12/2012 11:57 AM, Kent Yoder wrote:
>
> This code looks clean - my only suggestion would be to add an #ifdef
> CONFIG_ACPI around it so it compiles out on ppc.
>
Better yet, any way to separate it out in a separate source file?
-hpa
prev parent reply other threads:[~2012-06-12 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 3:34 [PATCH 1/2] driver: add PPI support in tpm driver Zhang, Xiaoyan
2012-06-12 18:57 ` Kent Yoder
2012-06-12 19:00 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD791D6.5050503@zytor.com \
--to=hpa@zytor.com \
--cc=debora@linux.vnet.ibm.com \
--cc=gang.wei@intel.com \
--cc=james.l.morris@oracle.com \
--cc=joseph.cihula@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=m.selhorst@sirrix.com \
--cc=shpedoikal@gmail.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=xiaoyan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox