From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, jolsa@redhat.com,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support
Date: Wed, 13 Jun 2012 09:41:31 +0800 [thread overview]
Message-ID: <4FD7EFCB.6060005@intel.com> (raw)
In-Reply-To: <CABPqkBQu1hTa2R-PKsygLqOSSD9nu3+xR-79pT-8bB8Y16CBuw@mail.gmail.com>
On 06/12/2012 11:38 PM, Stephane Eranian wrote:
> On Tue, Jun 12, 2012 at 7:37 AM, Yan, Zheng <zheng.z.yan@intel.com> wrote:
>> Hi, all
>>
>> Here is the V5 patches to add uncore counting support for Nehalem,
>> Sandy Bridge and Sandy Bridge-EP, applied on top of current tip.
>> The code is based on Lin Ming's old patches.
>>
>> For Nehalem and Sandy Bridge-EP, A few general events are exported
>> under sysfs directory:
>> /sys/bus/event_source/devices/${uncore_dev}/events/
>>
> On NHM, I tried:
> perf stat -a -e Uncore/CLOCKTICKS/
> invalid or unsupported event: 'Uncore/CLOCKTICKS/'
Strange enough. Did you re-compile the perf tool? Are there
files under directory /sys/bus/event_source/devices/Uncore/events
>
> I started tracking this down but gave up because it's coming
> once again from the too complex parser. You are looking for
> a format match (inv, edge, cmask) with the word CLOCKTICKS
> instead of config.
>
> Please fix this.
>
> Also I don't think using upper case for the PMU name is a good idea.
> Just call it uncore.
>
Peter suggests keeping the uncore names as they're listed in the intel
doc. For Sandybirdge-EP, uncore names are something like: Cbo, iMC, QPI.
I think Uncore_Cbo_0 appears better than uncore_Cbo_0
Regards
Yan, Zheng
>
>> Each file in the events directory defines an event. The content is
>> a string such as:
>> config=1,config1=2
>>
>> You can use 'perf stat' to access to the uncore pmu. For example:
>> perf stat -a -C 0 -e 'Uncore_iMC_0/CAS_COUNT_RD/' sleep 1
>> perf stat -a -C 0 -e 'Uncore_iMC_0/event=CAS_COUNT_RD/' sleep 1
>>
>> Any comment is appreciated.
>> Thank you
>> ---
>> Changes since v1:
>> - Modify perf tool to parse events from sysfs
>> - A few minor code cleanup
>>
>> Changes since v2:
>> - Place all events for a particular socket onto a single cpu
>> - Make the events parser in perf tool reentrantable
>> - A few code cleanup
>>
>> Changes since v3:
>> - Use per cpu pointer to track uncore box
>> - Rework the cpu hotplug code because topology_physical_package_id()
>> return wrong result when the cpu is offline
>> - Rework the event alias code, event terms are stored in the alias
>> structure instead events string
>>
>> Changes since v4:
>> - Include Jiri's uncore related changes patch set
>> - Add pmu/event=alias/ syntax support
>>
next prev parent reply other threads:[~2012-06-13 1:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 5:37 [PATCH V5 0/13] perf: Intel uncore pmu counting support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 01/13] perf: Export perf_assign_events Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 02/13] perf: Avoid race between cpu hotplug and installing event Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 03/13] perf: Allow pmu to choose cpu on which to install event Yan, Zheng
2012-06-12 10:17 ` Stephane Eranian
2012-06-13 1:57 ` Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 04/13] perf: Introduce perf_pmu_migrate_context Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 05/13] perf: Generic intel uncore support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 06/13] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 07/13] perf: Generic pci uncore device support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 08/13] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 09/13] perf, tool: Use data struct for arg passing in event parse function Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 10/13] perf, tool: Make the event parser reentrantable Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 11/13] perf, tool: Add support to reuse event grammar to parse out terms Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 12/13] perf, tool: Add pmu event alias support Yan, Zheng
2012-06-13 6:58 ` Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 13/13] perf, tool: Add automated test for pure terms parsing Yan, Zheng
2012-06-12 15:38 ` [PATCH V5 0/13] perf: Intel uncore pmu counting support Stephane Eranian
2012-06-13 1:41 ` Yan, Zheng [this message]
2012-06-13 3:31 ` Andi Kleen
2012-06-13 7:44 ` Ingo Molnar
2012-06-13 6:37 ` Stephane Eranian
2012-06-13 7:38 ` Ingo Molnar
2012-06-13 9:02 ` Peter Zijlstra
2012-06-14 2:18 ` Yan, Zheng
2012-06-14 5:41 ` Stephane Eranian
2012-06-27 1:05 ` Stephane Eranian
2012-06-27 2:09 ` Yan, Zheng
2012-06-27 9:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD7EFCB.6060005@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).