From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, jolsa@redhat.com,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 03/13] perf: Allow pmu to choose cpu on which to install event
Date: Wed, 13 Jun 2012 09:57:25 +0800 [thread overview]
Message-ID: <4FD7F385.1090303@intel.com> (raw)
In-Reply-To: <CABPqkBRepH-=j3Y9qJ1kXTkTv3_p0wC=Kzu+q=7rdxwk8vxk6A@mail.gmail.com>
On 06/12/2012 06:17 PM, Stephane Eranian wrote:
> On Tue, Jun 12, 2012 at 7:37 AM, Yan, Zheng <zheng.z.yan@intel.com> wrote:
>> From: "Yan, Zheng" <zheng.z.yan@intel.com>
>>
>> Allow the pmu->event_init callback to change event->cpu, so pmu can
>> choose cpu on which to install event.
>>
> So now, the user can say perf record -e xxxx -C 1 -a and then get nothing
> out of perf report -C1 because under the cover the kernel has swapped
> it for another CPU?
This change is for uncore, it does not support 'perf report'.
Regards
Yan, Zheng
>
>> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
>> ---
>> kernel/events/core.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index d71a2d6..2c05027 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -6302,7 +6302,7 @@ SYSCALL_DEFINE5(perf_event_open,
>> /*
>> * Get the target context (task or percpu):
>> */
>> - ctx = find_get_context(pmu, task, cpu);
>> + ctx = find_get_context(pmu, task, event->cpu);
>> if (IS_ERR(ctx)) {
>> err = PTR_ERR(ctx);
>> goto err_alloc;
>> @@ -6375,16 +6375,16 @@ SYSCALL_DEFINE5(perf_event_open,
>> mutex_lock(&ctx->mutex);
>>
>> if (move_group) {
>> - perf_install_in_context(ctx, group_leader, cpu);
>> + perf_install_in_context(ctx, group_leader, event->cpu);
>> get_ctx(ctx);
>> list_for_each_entry(sibling, &group_leader->sibling_list,
>> group_entry) {
>> - perf_install_in_context(ctx, sibling, cpu);
>> + perf_install_in_context(ctx, sibling, event->cpu);
>> get_ctx(ctx);
>> }
>> }
>>
>> - perf_install_in_context(ctx, event, cpu);
>> + perf_install_in_context(ctx, event, event->cpu);
>> ++ctx->generation;
>> perf_unpin_context(ctx);
>> mutex_unlock(&ctx->mutex);
>> --
>> 1.7.10.2
>>
next prev parent reply other threads:[~2012-06-13 1:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 5:37 [PATCH V5 0/13] perf: Intel uncore pmu counting support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 01/13] perf: Export perf_assign_events Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 02/13] perf: Avoid race between cpu hotplug and installing event Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 03/13] perf: Allow pmu to choose cpu on which to install event Yan, Zheng
2012-06-12 10:17 ` Stephane Eranian
2012-06-13 1:57 ` Yan, Zheng [this message]
2012-06-12 5:37 ` [PATCH V5 04/13] perf: Introduce perf_pmu_migrate_context Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 05/13] perf: Generic intel uncore support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 06/13] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 07/13] perf: Generic pci uncore device support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 08/13] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 09/13] perf, tool: Use data struct for arg passing in event parse function Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 10/13] perf, tool: Make the event parser reentrantable Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 11/13] perf, tool: Add support to reuse event grammar to parse out terms Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 12/13] perf, tool: Add pmu event alias support Yan, Zheng
2012-06-13 6:58 ` Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 13/13] perf, tool: Add automated test for pure terms parsing Yan, Zheng
2012-06-12 15:38 ` [PATCH V5 0/13] perf: Intel uncore pmu counting support Stephane Eranian
2012-06-13 1:41 ` Yan, Zheng
2012-06-13 3:31 ` Andi Kleen
2012-06-13 7:44 ` Ingo Molnar
2012-06-13 6:37 ` Stephane Eranian
2012-06-13 7:38 ` Ingo Molnar
2012-06-13 9:02 ` Peter Zijlstra
2012-06-14 2:18 ` Yan, Zheng
2012-06-14 5:41 ` Stephane Eranian
2012-06-27 1:05 ` Stephane Eranian
2012-06-27 2:09 ` Yan, Zheng
2012-06-27 9:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD7F385.1090303@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).