Re: [PATCH 3/3] deal with guest panicked event

[Wen Congyang <wency@cn.fujitsu.com>]

At 06/12/2012 09:29 PM, Paolo Bonzini Wrote:
> Il 21/05/2012 08:50, Wen Congyang ha scritto:
>> +DEF("onpanic", HAS_ARG, QEMU_OPTION_onpanic, \
>> +    "-onpanic report|pause|quit\n" \
>> +    "                action when the guest is panicked [default=report]",
>> +    QEMU_ARCH_ALL)
>> +STEXI
>> +@item -onpanic @var{action}
>> +
>> +The @var{action} controls what QEmu will do when the guest is panicked.
>> +The default is @code{report} (emit QEVENT_GUEST_PANICKED only).
> 
> -watchdog-action just calls this "none".

Yes, I will change the action name.

> 
>> +Other possible actions are:
>> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM),
>> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM).
> 
> Rather than just "quit", there should be choices for "shutdown",
> "poweroff" and "reset" for consistency with -watchdog-action.

Hmm, quit means poweroff. I will add reset, but I think we donot
need shutdown, because we cannot shutdown the system when it is
panicked.

> 
> Also, this option should also be accessible from "-machine", please.

I don't understand this. Do you mean we can also specify this action
in -machine option?

Thanks
Wen Congyang

> 
> Paolo
> 
>> +ETEXI
>> +
>>  HXCOMM This is the last statement. Insert new options before this line!
>>  STEXI
>>  @end table
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>