public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] regmap: Remove warning on stubbed dev_get_regmap()
Date: Wed, 13 Jun 2012 15:20:30 +0100	[thread overview]
Message-ID: <4FD8A1AE.3040003@linaro.org> (raw)
In-Reply-To: <1339594736-6712-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On 13/06/12 14:38, Mark Brown wrote:
> It's perfectly sensible to ask if there's a regmap for a device which
> doesn't have one so the stubbed version shouldn't complain, the caller
> should be prepared for this.
>
> Signed-off-by: Mark Brown<broonie@opensource.wolfsonmicro.com>
> ---
>   include/linux/regmap.h |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index 4c9e642..c3508d0 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -388,7 +388,6 @@ static inline int regmap_register_patch(struct regmap *map,
>   static inline struct regmap *dev_get_regmap(struct device *dev,
>   					    const char *name)
>   {
> -	WARN_ONCE(1, "regmap API is disabled");
>   	return NULL;
>   }

Thanks Mark.

Reported-by: Lee Jones <lee.jones@linaro.org>
Tested-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2012-06-13 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 13:38 [PATCH] regmap: Remove warning on stubbed dev_get_regmap() Mark Brown
2012-06-13 14:20 ` Lee Jones [this message]
2012-06-13 15:27 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD8A1AE.3040003@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox