From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH 2/2] msync: start async writeout when MS_ASYNC
Date: Thu, 14 Jun 2012 14:24:51 +0200 [thread overview]
Message-ID: <4FD9D813.1010203@redhat.com> (raw)
In-Reply-To: <20120613142949.734818a8.akpm@linux-foundation.org>
Il 13/06/2012 23:29, Andrew Morton ha scritto:
> Also, it hardwires into the kernel behaviour which userspace itself
> could have initiated, with sync_file_range(). ie: reduced flexibility.
Actually sync_file_range calls filemap_fdatawrite_range with
WB_SYNC_ALL, hence it does the writeout synchronously and can block for
an extended period of time. Hence sync_file_range is more similar to
MS_SYNC except without the metadata write.
Instead, this patch uses WB_SYNC_NONE, while still using tag-and-write
to avoid livelock.
I'll wait a day or two to let others voice their opinions, and then send
a fixed v2 with updated commit messages from this discussion.
Paolo
next prev parent reply other threads:[~2012-06-14 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 20:43 [PATCH 0/2] msync improvements Paolo Bonzini
2012-05-31 20:43 ` [PATCH 1/2] msync: support syncing a small part of the file Paolo Bonzini
2012-06-13 21:26 ` Andrew Morton
2012-06-13 21:51 ` Zan Lynx
2012-06-13 22:08 ` Andrew Morton
2012-06-14 8:57 ` Paolo Bonzini
2012-05-31 20:43 ` [PATCH 2/2] msync: start async writeout when MS_ASYNC Paolo Bonzini
2012-06-13 21:29 ` Andrew Morton
2012-06-14 9:02 ` Paolo Bonzini
2012-06-14 10:07 ` Andrew Morton
2012-06-14 10:19 ` Paolo Bonzini
2012-06-14 12:24 ` Paolo Bonzini [this message]
2012-06-12 15:38 ` [PATCH 0/2] msync improvements Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD9D813.1010203@redhat.com \
--to=pbonzini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox