RE: linux-next: Tree for Jun 14 (staging/comedi)

H Hartley Sweeten
2012-06-15T16:12:35Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2771 bytes --]

On Friday, June 15, 2012 4:25 AM, Ian Abbott wrote:
> On 2012-06-14 22:38, Randy Dunlap wrote:
>> On 06/13/2012 11:29 PM, Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20120613:
>>
>>
>>
>> when CONFIG_PCMCIA is not enabled:
>>
>> ERROR: "pcmcia_unregister_driver" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_register_driver" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_enable_device" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_loop_config" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_request_io" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_disable_device" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_unregister_driver" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_register_driver" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_enable_device" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_loop_config" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_request_io" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_disable_device" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>>
>>
>> Full randconfig file is attached.
>
> This seems to be caused by this commit in the linux-next repository:
>
> 4829a9967dbe3a3ab192df0bfdde281960cc1319 is the first bad commit
> commit 4829a9967dbe3a3ab192df0bfdde281960cc1319
> Author: H Hartley Sweeten <hartleys@visionengravers.com>
> Date: Tue Jun 12 17:37:10 2012 -0700
>
> staging: comedi: Kconfig: cleanup depends on logic
>
> All of the config options for comedi depend on COMEDI being
> selected. Wrap everything in an 'if COMEDI/endif' block and
> remove all the individual 'depends on COMEDI' in the Kconfig.
>
> Also, remove the redundant && ISA/PCI/PCMCIA/USB for the if
> blocks with those driver types.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbott@mev.co.uk>
> Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>

OK. The problem appears to be in the depends for COMEDI_PCMCIA_DRIVERS.

menuconfig COMEDI_PCMCIA_DRIVERS
tristate "Comedi PCMCIA drivers"
depends on (PCMCIA || PCCARD)

Depending on PCCARD is redundant. It must be enabled in order to select
PCMCIA. Patch coming shortly.

Sorry about that.

Regards,
Hartley

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥