From: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
To: gregkh@linuxfoundation.org
Cc: james.smart@emulex.com, linux-kernel@vger.kernel.org
Subject: Driver scsi/lpfc breaks build since 3.4.1
Date: Mon, 18 Jun 2012 02:09:08 +0200 [thread overview]
Message-ID: <4FDE71A4.2090807@mni.thm.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
Hello there,
since 3.4.1 the driver scsi/lpfc breaks my build for some unused variables:
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl’:
drivers/scsi/lpfc/lpfc_scsi.c:1900:11: error: unused variable ‘rc’
[-Werror=unused-variable]
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl_prot’:
drivers/scsi/lpfc/lpfc_scsi.c:2037:11: error: unused variable ‘rc’
[-Werror=unused-variable]
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl’:
drivers/scsi/lpfc/lpfc_scsi.c:2256:11: error: unused variable ‘rc’
[-Werror=unused-variable]
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl_prot’:
drivers/scsi/lpfc/lpfc_scsi.c:2386:11: error: unused variable ‘rc’
[-Werror=unused-variable]
cc1: all warnings being treated as errors
From the drivers makefile:
ccflags-y += -Werror <- this causes the bad behavior.
=> remove this line or the unused variables
=> decided to remove the unused varaibles for 3.4.x and create a patch
for it. Maybe you want to queue it up for the 3.4.y stable series!
Greetings
Tobias Klausmann
[-- Attachment #2: lpfc_compile_fix.diff --]
[-- Type: text/x-patch, Size: 1551 bytes --]
>From 69c2b0224847f6b7f6fb701fe0cb0c5657f1389b Mon Sep 17 00:00:00 2001
From: Tobias Klausmann <tobias.klausmann@mni.thm.de>
Date: Mon, 18 Jun 2012 01:14:55 +0200
Subject: [PATCH] Driver scsi/lpfc: Remove some unused varaibles (Compilefix
for linux 3.4.1-3.4.x)
---
drivers/scsi/lpfc/lpfc_scsi.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 88f3a83..7f20599 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -1897,7 +1897,6 @@ lpfc_bg_setup_bpl(struct lpfc_hba *phba, struct scsi_cmnd *sc,
dma_addr_t physaddr;
int i = 0, num_bde = 0, status;
int datadir = sc->sc_data_direction;
- uint32_t rc;
uint32_t checking = 1;
uint32_t reftag;
unsigned blksize;
@@ -2034,7 +2033,6 @@ lpfc_bg_setup_bpl_prot(struct lpfc_hba *phba, struct scsi_cmnd *sc,
int datadir = sc->sc_data_direction;
unsigned char pgdone = 0, alldone = 0;
unsigned blksize;
- uint32_t rc;
uint32_t checking = 1;
uint32_t reftag;
uint8_t txop, rxop;
@@ -2253,7 +2251,6 @@ lpfc_bg_setup_sgl(struct lpfc_hba *phba, struct scsi_cmnd *sc,
uint32_t reftag;
unsigned blksize;
uint8_t txop, rxop;
- uint32_t rc;
uint32_t checking = 1;
uint32_t dma_len;
uint32_t dma_offset = 0;
@@ -2383,7 +2380,6 @@ lpfc_bg_setup_sgl_prot(struct lpfc_hba *phba, struct scsi_cmnd *sc,
uint32_t reftag;
uint8_t txop, rxop;
uint32_t dma_len;
- uint32_t rc;
uint32_t checking = 1;
uint32_t dma_offset = 0;
int num_sge = 0;
--
1.7.7
next reply other threads:[~2012-06-18 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 0:09 Tobias Klausmann [this message]
2012-06-18 1:24 ` Driver scsi/lpfc breaks build since 3.4.1 Greg KH
2012-06-18 14:48 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDE71A4.2090807@mni.thm.de \
--to=tobias.johannes.klausmann@mni.thm.de \
--cc=gregkh@linuxfoundation.org \
--cc=james.smart@emulex.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox