From: Chen Gong <gong.chen@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: tony.luck@intel.com, borislav.petkov@amd.com, x86@kernel.org,
peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] tmp patch to fix hotplug issue in CMCI storm
Date: Mon, 18 Jun 2012 18:13:39 +0800 [thread overview]
Message-ID: <4FDEFF53.9040902@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1206180952070.3086@ionos>
于 2012/6/18 16:00, Thomas Gleixner 写道:
> On Mon, 18 Jun 2012, Chen Gong wrote:
>> index 92d8b5c..0493525 100644
>> --- a/arch/x86/kernel/cpu/mcheck/mce_intel.c
>> +++ b/arch/x86/kernel/cpu/mcheck/mce_intel.c
>> @@ -40,6 +40,7 @@ static DEFINE_RAW_SPINLOCK(cmci_discover_lock);
>> static DEFINE_PER_CPU(unsigned long, cmci_time_stamp);
>> static DEFINE_PER_CPU(unsigned int, cmci_storm_cnt);
>> static DEFINE_PER_CPU(unsigned int, cmci_storm_state);
>> +static DEFINE_PER_CPU(unsigned long, cmci_storm_hcpu_status);
>
> Why do you insist on having another status variable, which does
> actually nothing than obfuscate the code?
>
> Look at the usage sites:
>
>> __this_cpu_write(cmci_storm_state, CMCI_STORM_SUBSIDED);
>> + __this_cpu_write(cmci_storm_hcpu_status, CMCI_STORM_HCPU_NONE);
Because here I can't substitute CMCI_STORM_HCPU_NONE with
CMCI_STORM_SUBSIDED. If so, the status is chaos.
next prev parent reply other threads:[~2012-06-18 10:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:53 [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version Thomas Gleixner
2012-06-06 21:53 ` [patch 1/5] x86: mce: Disable preemption when calling raise_local() Thomas Gleixner
2012-06-06 21:53 ` [patch 2/5] x86: mce: Serialize mce injection Thomas Gleixner
2012-06-06 21:53 ` [patch 3/5] x86: mce: Split timer init Thomas Gleixner
2012-06-07 15:18 ` Borislav Petkov
2012-06-20 3:35 ` Hidetoshi Seto
2012-06-06 21:53 ` [patch 4/5] x86: mce: Remove the frozen cases in the hotplug code Thomas Gleixner
2012-06-07 17:49 ` Borislav Petkov
2012-06-06 21:53 ` [patch 5/5] x86: mce: Add cmci poll mode Thomas Gleixner
2012-06-07 18:14 ` Borislav Petkov
2012-06-07 10:08 ` [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-06-07 13:35 ` Borislav Petkov
2012-06-07 16:22 ` Luck, Tony
2012-06-08 7:49 ` Thomas Gleixner
2012-06-11 5:46 ` Chen Gong
2012-06-11 6:09 ` Chen Gong
2012-06-14 13:49 ` [PATCH] tmp patch to fix hotplug issue in CMCI storm Chen Gong
2012-06-14 14:07 ` Thomas Gleixner
2012-06-15 6:51 ` Chen Gong
2012-06-15 9:55 ` Thomas Gleixner
2012-06-18 6:42 ` Chen Gong
2012-06-18 6:45 ` [PATCH V2] " Chen Gong
2012-06-18 8:00 ` Thomas Gleixner
2012-06-18 10:13 ` Chen Gong [this message]
2012-06-18 12:23 ` Thomas Gleixner
2012-06-19 6:05 ` Chen Gong
2012-06-19 6:09 ` [PATCH V3] " Chen Gong
2012-07-04 8:12 ` Chen Gong
2012-07-16 3:16 ` Chen Gong
2012-07-16 8:22 ` Thomas Gleixner
2012-07-17 21:47 ` Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDEFF53.9040902@linux.intel.com \
--to=gong.chen@linux.intel.com \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).