From: "Miguel Gómez" <magomez@igalia.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: arnaud.patard@rtp-net.org, aaro.koskinen@iki.fi,
dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Staging: xgifb: reorder the code a bit to be more module friendly
Date: Mon, 18 Jun 2012 12:52:10 +0200 [thread overview]
Message-ID: <4FDF085A.7030805@igalia.com> (raw)
In-Reply-To: <20120612000151.GA16887@kroah.com>
>> /*****************************************************/
>> /* MODULE */
>> /*****************************************************/
>>
>> -MODULE_DESCRIPTION("Z7 Z9 Z9S Z11 framebuffer device driver");
>> -MODULE_LICENSE("GPL");
>> -MODULE_AUTHOR("XGITECH , Others");
>> -
>> module_param(mode, charp, 0);
>> -module_param(vesa, int, 0);
>> -module_param(filter, int, 0);
>> -module_param(forcecrt2type, charp, 0);
>> +MODULE_PARM_DESC(mode,
>> + "\nSelects the desired default display mode in the format XxYxDepth,\n"
>> + "eg. 1024x768x16.\n");
>>
>> +module_param(forcecrt2type, charp, 0);
>> MODULE_PARM_DESC(forcecrt2type,
>> "\nForce the second display output type. Possible values are NONE,\n"
>> "LCD, TV, VGA, SVIDEO or COMPOSITE.\n");
>
> What's with these "\n" in the string? Shouldn't those be removed?
Sure, I'll clean them in the next round of patches :)
(sorry for the delay)
Cheers!
--
Miguel Gómez
Igalia - http://www.igalia.com
next prev parent reply other threads:[~2012-06-18 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 14:22 [PATCH 1/4] Staging: xgifb: Remove #ifdef MODULE Miguel Gómez
2012-06-06 14:22 ` [PATCH 2/4] Staging: xgifb: reorder the code a bit to be more module friendly Miguel Gómez
2012-06-12 0:01 ` Greg KH
2012-06-18 10:52 ` Miguel Gómez [this message]
2012-06-06 14:22 ` [PATCH 3/4] Staging: xgifb: disable pci device if there's an error after enabling it Miguel Gómez
2012-06-06 14:22 ` [PATCH 4/4] Staging: xgifb: disable pci device on pci remove function Miguel Gómez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF085A.7030805@igalia.com \
--to=magomez@igalia.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox