From: David Ahern <dsahern@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
acme@ghostprotocols.net, linux-kernel@vger.kernel.org,
weisbec@gmail.com, namhyung.kim@lge.com, mingo@kernel.org,
peterz@infradead.org
Subject: Re: [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd plugins
Date: Mon, 18 Jun 2012 08:35:07 -0600 [thread overview]
Message-ID: <4FDF3C9B.5060502@gmail.com> (raw)
In-Reply-To: <1340029292.25903.101.camel@gandalf.stny.rr.com>
On 6/18/12 8:21 AM, Steven Rostedt wrote:
>
> Anyway, I think it is important to get this into either libtraceevent or
> another library, but I agree with Namhyung that it should not go in, in
> its current form.
Great. No resistance to bringing this in.
> Either we add the 'pevent_' names to it, and we need to change things a
> bit.
Sure, namespace cleanup is trivial.
> I want to redesign the plugin interface. Well, I do not need to be the
> one to redesign it, but it needs to be updated by someone.
>
> Plugins need an interface that they can take parameters, or be modified
> at run time. An option passed to perf or trace-cmd could modify how the
> plugin works. Or during viewing of the output, parameters can be passed
> to tell plugins to do things differently.
>
> Basically, we need to discuss the interface between plugins and the
> libtraceevent library. Once we get a good idea of what is needed, then
> we can start reusing the code from trace-cmd to make a much better
> interface for users.
Ok. I'll poke around with this over the summer as I get spare time.
David
next prev parent reply other threads:[~2012-06-18 14:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 17:35 [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd plugins David Ahern
2012-06-14 17:35 ` [RFC PATCH 1/2] libtraceevent: Add support for tracecmd plugins David Ahern
2012-06-14 17:35 ` [RFC PATCH 2/2] perf: add support for trace-cmd plugins David Ahern
2012-06-18 8:35 ` [RFC PATCH 0/2] libtraceevent/perf: Add " Namhyung Kim
2012-06-18 14:21 ` Steven Rostedt
2012-06-18 14:35 ` David Ahern [this message]
2012-06-18 14:38 ` David Ahern
2012-06-19 0:45 ` Namhyung Kim
2012-06-19 1:03 ` Steven Rostedt
2012-06-19 1:11 ` Namhyung Kim
2012-06-19 1:26 ` Steven Rostedt
2012-06-19 1:40 ` Namhyung Kim
2012-06-19 2:16 ` Steven Rostedt
2012-06-19 5:41 ` Namhyung Kim
2012-06-19 11:54 ` Steven Rostedt
2012-06-19 14:39 ` Namhyung Kim
2012-06-19 14:44 ` Steven Rostedt
2012-06-19 1:14 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF3C9B.5060502@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=weisbec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox