From: James Smart <james.smart@emulex.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Driver scsi/lpfc breaks build since 3.4.1
Date: Mon, 18 Jun 2012 10:48:18 -0400 [thread overview]
Message-ID: <4FDF3FB2.2060300@emulex.com> (raw)
In-Reply-To: <20120618012401.GA13192@kroah.com>
fyi - the patch to lpfc to resolve this were submitted a while ago:
http://marc.info/?l=linux-scsi&m=133661285100503&w=2
-- james s
On 6/17/2012 9:24 PM, Greg KH wrote:
> On Mon, Jun 18, 2012 at 02:09:08AM +0200, Tobias Klausmann wrote:
>> Hello there,
>> since 3.4.1 the driver scsi/lpfc breaks my build for some unused variables:
>> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl’:
>> drivers/scsi/lpfc/lpfc_scsi.c:1900:11: error: unused variable ‘rc’
>> [-Werror=unused-variable]
>> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl_prot’:
>> drivers/scsi/lpfc/lpfc_scsi.c:2037:11: error: unused variable ‘rc’
>> [-Werror=unused-variable]
>> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl’:
>> drivers/scsi/lpfc/lpfc_scsi.c:2256:11: error: unused variable ‘rc’
>> [-Werror=unused-variable]
>> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl_prot’:
>> drivers/scsi/lpfc/lpfc_scsi.c:2386:11: error: unused variable ‘rc’
>> [-Werror=unused-variable]
>> cc1: all warnings being treated as errors
>>
>> From the drivers makefile:
>> ccflags-y += -Werror <- this causes the bad behavior.
> As has been stated before, this ccflags setting is what needs to be
> fixed, not trying to fix up the warnings here (although that is a good
> goal overall.)
>
> Also, this isn't how to submit a patch to the stable kernel tree, please
> read Documentation/stable_kernel_rules.txt for how to properly do that.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2012-06-18 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 0:09 Driver scsi/lpfc breaks build since 3.4.1 Tobias Klausmann
2012-06-18 1:24 ` Greg KH
2012-06-18 14:48 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF3FB2.2060300@emulex.com \
--to=james.smart@emulex.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobias.johannes.klausmann@mni.thm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox