From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Joonyoung Shim <jy0922.shim@samsung.com>,
linux-input@vger.kernel.org,
Iiro Valkonen <iiro.valkonen@atmel.com>,
Benson Leung <bleung@chromium.org>,
Yufeng Shen <miletus@chromium.org>,
Olof Johansson <olofj@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix after applying pdata
Date: Mon, 18 Jun 2012 16:03:33 +0100 [thread overview]
Message-ID: <4FDF4345.40508@itdev.co.uk> (raw)
In-Reply-To: <1339992522-22073-15-git-send-email-djkurtz@chromium.org>
Daniel Kurtz wrote:
> The matrix x/y size in the Info ID Block represents the number of x/y
> trace lines on the device. There is no need to re-read them after
> applying pdata config, since pdata only configures the object table
> etnries. The matrix size read from the ID can only be updated by a
> firmware update.
This isn't correct. For example, mXT224 can be configured as 16x14, 17x13,
18x12, etc. This only takes effect when the chip is reset, which is why it
is necessary to re-read them after applying the config.
cheers
--
Nick Dyer
Software Engineer, ITDev Ltd
Hardware and Software Development Consultancy
Website: http://www.itdev.co.uk
next prev parent reply other threads:[~2012-06-18 15:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 4:08 [PATCH 00/22 v4] cleanup atmel_mxt_ts Daniel Kurtz
2012-06-18 4:08 ` [PATCH 01/22 v4] Input: atmel_mxt_ts - set phys to i2c client adapter name Daniel Kurtz
2012-06-21 8:41 ` Dmitry Torokhov
2012-06-25 8:15 ` Henrik Rydberg
2012-06-25 9:58 ` Daniel Kurtz
2012-06-26 1:27 ` Dmitry Torokhov
2012-06-27 0:42 ` Benson Leung
2012-06-18 4:08 ` [PATCH 02/22 v4] Input: atmel_mxt_ts - use client name for irq Daniel Kurtz
2012-06-18 4:08 ` [PATCH 03/22 v4] Input: atmel_mxt_ts - detect OOM when creating mt slots Daniel Kurtz
2012-06-18 4:08 ` [PATCH 04/22 v4] Input: atmel_mxt_ts - warn if sysfs could not be created Daniel Kurtz
2012-06-18 4:08 ` [PATCH 05/22 v4] Input: atmel_mxt_ts - don't read T5 when dumping objects Daniel Kurtz
2012-06-18 4:08 ` [PATCH 06/22 v4] Input: atmel_mxt_ts - use scnprintf for object sysfs entry Daniel Kurtz
2012-06-18 4:08 ` [PATCH 07/22 v4] Input: atmel_mxt_ts - optimize reading objects in " Daniel Kurtz
2012-06-18 4:08 ` [PATCH 08/22 v4] Input: atmel_mxt_ts - print less overhead when dumping objects Daniel Kurtz
2012-06-18 4:08 ` [PATCH 09/22 v4] Input: atmel_mxt_ts - print all instances " Daniel Kurtz
2012-06-18 4:08 ` [PATCH 10/22 v4] Input: atmel_mxt_ts - return errors from i2c layer Daniel Kurtz
2012-06-18 4:08 ` [PATCH 11/22 v4] Input: atmel_mxt_ts - add variable length __mxt_write_reg Daniel Kurtz
2012-06-18 4:08 ` [PATCH 12/22 v4] Input: atmel_mxt_ts - optimize writing of object table entries Daniel Kurtz
2012-06-18 4:08 ` [PATCH 13/22 v4] Input: atmel_mxt_ts - read ID information block in one i2c transaction Daniel Kurtz
2012-06-18 4:08 ` [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix after applying pdata Daniel Kurtz
2012-06-18 15:03 ` Nick Dyer [this message]
2012-06-18 15:28 ` Daniel Kurtz
2012-06-18 19:50 ` Yufeng Shen
2012-06-19 10:26 ` Nick Dyer
2012-06-19 15:12 ` Yufeng Shen
2012-06-18 4:08 ` [PATCH 15/22 v4] Input: atmel_mxt_ts - update driver ID info logging Daniel Kurtz
2012-06-18 4:08 ` [PATCH 16/22 v4] Input: atmel_mxt_ts - add sysfs entries to read fw and hw version Daniel Kurtz
2012-06-18 4:08 ` [PATCH 17/22 v4] Input: atmel_mxt_ts - simplify event reporting Daniel Kurtz
2012-06-18 4:08 ` [PATCH 18/22 v4] Input: atmel_mxt_ts - add detail to touchevent debug message Daniel Kurtz
2012-06-18 4:08 ` [PATCH 19/22 v4] Input: atmel_mxt_ts - cache T9 reportid range when reading object table Daniel Kurtz
2012-06-18 4:08 ` [PATCH 20/22 v4] Input: atmel_mxt_ts - use T9 reportid range to init number of mt slots Daniel Kurtz
2012-06-18 4:08 ` [PATCH 21/22 v4] Input: atmel_mxt_ts - send all MT-B slots in one input report Daniel Kurtz
2012-06-18 4:08 ` [PATCH 22/22 v4] Input: atmel_mxt_ts - parse T6 reports Daniel Kurtz
2012-06-18 15:09 ` Nick Dyer
2012-06-18 15:29 ` Daniel Kurtz
2012-06-20 17:38 ` [PATCH 00/22 v4] cleanup atmel_mxt_ts Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF4345.40508@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=iiro.valkonen@atmel.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=olofj@chromium.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox