From: Stephen Warren <swarren@wwwdotorg.org>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Stephen Warren <swarren@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl
Date: Mon, 18 Jun 2012 12:05:18 -0600 [thread overview]
Message-ID: <4FDF6DDE.3020306@wwwdotorg.org> (raw)
In-Reply-To: <1340041471-30122-1-git-send-email-devendra.aaru@gmail.com>
On 06/18/2012 11:44 AM, Devendra Naga wrote:
> pinctrl_register returns a pointer of struct type struct pinctrl_dev,
> if successfully registered to pinctrl subsystem, otherwise returns
> NULL, and there wont' be any pointers which are not dereferencible.
>
> They are not type of pointer addresses but are kind of error
> codes rather actual addresses, but are a kind of return
> codes of functions returning integer types.
>
> return -ENODEV if device registration fails.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Oops.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Probably Cc stable since this is wrong back as far as 3.4.
next prev parent reply other threads:[~2012-06-18 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 17:44 [PATCH 1/2] pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl Devendra Naga
2012-06-18 18:05 ` Stephen Warren [this message]
2012-06-20 8:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF6DDE.3020306@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devendra.aaru@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox