From: "H. Peter Anvin" <hpa@zytor.com>
To: Olof Johansson <olof@lixom.net>
Cc: Marko Kohtala <marko.kohtala@gmail.com>,
Matthew Garrett <mjg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efivars: prevent Oops if efi_enabled but no EFI runtime
Date: Mon, 18 Jun 2012 13:22:56 -0700 [thread overview]
Message-ID: <4FDF8E20.5050606@zytor.com> (raw)
In-Reply-To: <CAOesGMi2nAecB4Lgti-JSrNTuV4MRA9GEQV1T=BrDxJ-QCq+cQ@mail.gmail.com>
On 06/17/2012 04:00 PM, Olof Johansson wrote:
>
> I think it would make more sense to return -ENODEV when the function
> pointers aren't set, that way the exit function won't ever be called
> either, so no need to add the checks there.
>
-ENIXO? ENODEV is usually some form of "wrong type of device"; ENXIO is
"device is not there."
-hpa
prev parent reply other threads:[~2012-06-18 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 20:47 [PATCH] efivars: prevent Oops if efi_enabled but no EFI runtime Marko Kohtala
2012-06-17 23:00 ` Olof Johansson
2012-06-18 20:06 ` Marko Kohtala
2012-06-27 21:35 ` [PATCH] efi: add efi_runtime state checking Olof Johansson
2012-06-27 21:52 ` H. Peter Anvin
2012-06-28 17:02 ` Olof Johansson
2012-08-15 0:51 ` H. Peter Anvin
2012-08-18 13:39 ` Matt Fleming
2012-06-18 20:22 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF8E20.5050606@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marko.kohtala@gmail.com \
--cc=mjg@redhat.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).