From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754030Ab2FSCT3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jun 2012 22:19:29 -0400
Received: from e23smtp07.au.ibm.com ([202.81.31.140]:48161 "EHLO
	e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753740Ab2FSCSF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jun 2012 22:18:05 -0400
Message-ID: <4FDFE14D.5060509@linux.vnet.ibm.com>
Date: Tue, 19 Jun 2012 10:17:49 +0800
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Avi Kivity <avi@redhat.com>
CC: Marcelo Tosatti <mtosatti@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 4/6] KVM: pass slot to hva_to_pfn
References: <4FD6ADA6.40008@linux.vnet.ibm.com> <4FD6ADF6.2030802@linux.vnet.ibm.com> <4FDEFFCA.7060403@redhat.com>
In-Reply-To: <4FDEFFCA.7060403@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
x-cbid: 12061816-0260-0000-0000-0000015C9F08
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/18/2012 06:15 PM, Avi Kivity wrote:

> On 06/12/2012 05:48 AM, Xiao Guangrong wrote:
>> This parameter will be used in the later patch
>>
>>
>> -	return hva_to_pfn(kvm, addr, atomic, async, write_fault, writable);
>> +	return hva_to_pfn(kvm, slot, addr, atomic, async, write_fault,
>> +			  writable);
>>  }
>>
>>  pfn_t gfn_to_pfn_atomic(struct kvm *kvm, gfn_t gfn)
>> @@ -1205,7 +1210,7 @@ pfn_t gfn_to_pfn_memslot(struct kvm *kvm,
>>  			 struct kvm_memory_slot *slot, gfn_t gfn)
>>  {
>>  	unsigned long addr = gfn_to_hva_memslot(slot, gfn);
>> -	return hva_to_pfn(kvm, addr, false, NULL, true, NULL);
>> +	return hva_to_pfn(kvm, slot, addr, false, NULL, true, NULL);
>>  }
>>
>>  pfn_t gfn_to_pfn_memslot_atomic(struct kvm *kvm,
>> @@ -1213,7 +1218,7 @@ pfn_t gfn_to_pfn_memslot_atomic(struct kvm *kvm,
>>  {
>>  	unsigned long addr = gfn_to_hva_memslot(slot, gfn);
>>
>> -	return hva_to_pfn(kvm, addr, true, NULL, true, NULL);
>> +	return hva_to_pfn(kvm, slot, addr, true, NULL, true, NULL);
>>  }
> 
> It was unreadable before, but now it's even more unreadable.


Hmm, i will simplify hva_to_pfn() in the next version.