From: Goffredo Baroncelli <kreijack@libero.it>
To: Calvin Walton <calvin.walton@kepstin.ca>
Cc: Alexander Block <ablock84@googlemail.com>,
kreijack@inwind.it, linux-btrfs@vger.kernel.org, dave@jikos.cz,
hch@infradead.org, linux-fsdevel@vger.kernel.org,
chris.mason@fusionio.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)
Date: Wed, 20 Jun 2012 20:11:38 +0200 [thread overview]
Message-ID: <4FE2125A.5080806@libero.it> (raw)
In-Reply-To: <1340215644.6961.12.camel@cwalton-XPS-8300>
On 06/20/2012 08:07 PM, Calvin Walton wrote:
> On Wed, 2012-06-20 at 19:27 +0200, Alexander Block wrote:
>> On Wed, Jun 20, 2012 at 7:18 PM, Goffredo Baroncelli <kreijack@libero.it> wrote:
>>> Hi Alexander,
>>>
>>> On 06/20/2012 12:35 PM, Alexander Block wrote:
>>>> The patch also does proper vfs mount checks, so cross mount
>>>> point reflinks are not possible with this patch. It only allows cross
>>>> reflinks between two subvolumes which are in the same mount point.
>>>
>>> Thanks for working on that. What happens if two subvolumes of the same
>>> filesystem are mounted on two different places ?
>>>
>>> I usually do:
>>> mount -o subvol=__active /dev/sdX /
>>> mount -o subvol=. /dev/sdX /var/btrfs
>>>
>>> So two different subvolumes of the same filesystem (the one on /dev/sdX)
>>> are mounted on two different places.
>>>
>>> Is it possible to do
>>> cp --reflink /tmp/foo /var/btrfs/tmp/foo2
>> This will fail with -EXDEV. The patch explicitly forbids reflinks crossing vfs
>> mount boundaries.
>
> Which means that if I want to do a reflink copy between two separately
> mounted subvolumes, I will have to go and do a third mount with a common
> subvolume above those two, then do the reflink operation within this
> extra mount? This seems slightly impractical.
>
> Is it any extra code to enable doing cross-mount reflinks? Why was the
> decision made not to allow them?
>
> Is there some particular opposition to supporting cross-mount operations
> on multiple mounts of the same filesystem in general? (I'd love to have
> rename() work across bind mounts, for example...)
Yes please, could someone explain the reason behind this decision ? May
be there are valid reasons, I am asking only to know which ones ?
next prev parent reply other threads:[~2012-06-20 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 10:35 [PATCH] Allow cross subvolume reflinks (2nd attempt) Alexander Block
2012-06-20 10:35 ` [PATCH] btrfs: allow cross-subvolume file clone Alexander Block
2012-06-20 17:18 ` [PATCH] Allow cross subvolume reflinks (2nd attempt) Goffredo Baroncelli
2012-06-20 17:27 ` Alexander Block
2012-06-20 18:07 ` Calvin Walton
2012-06-20 18:11 ` Goffredo Baroncelli [this message]
2012-06-20 20:05 ` Alexander Block
2012-06-20 20:15 ` Goffredo Baroncelli
2012-06-27 17:21 ` Marc MERLIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE2125A.5080806@libero.it \
--to=kreijack@libero.it \
--cc=ablock84@googlemail.com \
--cc=calvin.walton@kepstin.ca \
--cc=chris.mason@fusionio.com \
--cc=dave@jikos.cz \
--cc=hch@infradead.org \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).