From: Stephen Warren <swarren@wwwdotorg.org>
To: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: boot_on regulator constraint vs. regulator-boot-on DT property
Date: Wed, 20 Jun 2012 14:55:37 -0600 [thread overview]
Message-ID: <4FE238C9.3010408@wwwdotorg.org> (raw)
Liam, Mark,
I've spotted what seems like a slight inconsistency between the
documentation for the boot_on regulator constraint, and the
regulator-boot-on DT property documentation.
include/linux/regulator/machine.h says:
> * @boot_on: Set if the regulator is enabled when the system is initially
> * started. If the regulator is not enabled by the hardware or
> * bootloader then it will be enabled when the constraints are
> * applied.
Documentation/devicetree/bindings/regulator/regulator.txt says:
> - regulator-boot-on: bootloader/firmware enabled regulator
... and of_regulator.c sets the boot_on constraint based on this property.
The former quote implies that this is a flag to tell Linux to turn on
the regulator when it's first registered, whereas the latter quote
implies that it's guaranteeing the state that previous SW placed the
regulator into already.
I assume the documentation from machine.h is correct, and I should send
a patch to make regulator.txt match it?
Thanks.
next reply other threads:[~2012-06-20 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 20:55 Stephen Warren [this message]
2012-06-20 23:46 ` boot_on regulator constraint vs. regulator-boot-on DT property Mark Brown
2012-06-21 1:26 ` Stephen Warren
2012-06-21 9:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE238C9.3010408@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox