From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756259Ab2FUB0Q (ORCPT ); Wed, 20 Jun 2012 21:26:16 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:58186 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755672Ab2FUB0P (ORCPT ); Wed, 20 Jun 2012 21:26:15 -0400 Message-ID: <4FE27835.5070705@wwwdotorg.org> Date: Wed, 20 Jun 2012 19:26:13 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Mark Brown CC: Liam Girdwood , "linux-kernel@vger.kernel.org" Subject: Re: boot_on regulator constraint vs. regulator-boot-on DT property References: <4FE238C9.3010408@wwwdotorg.org> <20120620234648.GE4037@opensource.wolfsonmicro.com> In-Reply-To: <20120620234648.GE4037@opensource.wolfsonmicro.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2012 05:46 PM, Mark Brown wrote: > On Wed, Jun 20, 2012 at 02:55:37PM -0600, Stephen Warren wrote: > >> include/linux/regulator/machine.h says: > >>> * @boot_on: Set if the regulator is enabled when the system is >>> initially * started. If the regulator is not enabled >>> by the hardware or * bootloader then it will be >>> enabled when the constraints are * applied. > >> Documentation/devicetree/bindings/regulator/regulator.txt says: > >>> - regulator-boot-on: bootloader/firmware enabled regulator > >> ... and of_regulator.c sets the boot_on constraint based on this >> property. > >> The former quote implies that this is a flag to tell Linux to >> turn on the regulator when it's first registered, whereas the >> latter quote implies that it's guaranteeing the state that >> previous SW placed the regulator into already. > >> I assume the documentation from machine.h is correct, and I >> should send a patch to make regulator.txt match it? > > There's no great inconsistency between the two, this is only > supposed to be used for supplies which are already enabled on boot Hmm. Perhaps I was misreading machine.h, and "when the system is initially started" refers to the first firmware start, rather than when /Linux/ starts. If so, then yes I can see it isn't really inconsistent.