* [PATCH] gpio: gpiolib: fix conflicting flag values
@ 2012-06-22 11:48 Alexandre Courbot
2012-06-22 11:52 ` Laxman Dewangan
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2012-06-22 11:48 UTC (permalink / raw)
To: Grant Likely, Linus Walleij; +Cc: Laxman Dewangan, linux-kernel
Commits aca5ce14 and 25553ff0 introduced two new GPIOF_OPEN_DRAIN and
GPIOF_OPEN_SOURCE flags to gpiolib. Unfortunately they happen to be the
same as GPIOF_EXPORT and GPIOF_EXPORT_CHANGEABLE, which causes all gpios
exported at request time to end up open drain and/or open source.
Resolve the conflict by affecting free flags to GPIOF_EXPORT and
GPIOF_EXPORT_CHANGEABLE.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
include/linux/gpio.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio.h b/include/linux/gpio.h
index f07fc2d..2e31e8b 100644
--- a/include/linux/gpio.h
+++ b/include/linux/gpio.h
@@ -22,8 +22,8 @@
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 3)
-#define GPIOF_EXPORT (1 << 2)
-#define GPIOF_EXPORT_CHANGEABLE (1 << 3)
+#define GPIOF_EXPORT (1 << 4)
+#define GPIOF_EXPORT_CHANGEABLE (1 << 5)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)
--
1.7.11
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: gpiolib: fix conflicting flag values
2012-06-22 11:48 [PATCH] gpio: gpiolib: fix conflicting flag values Alexandre Courbot
@ 2012-06-22 11:52 ` Laxman Dewangan
2012-06-22 12:01 ` Alex Courbot
0 siblings, 1 reply; 3+ messages in thread
From: Laxman Dewangan @ 2012-06-22 11:52 UTC (permalink / raw)
To: Alexandre Courbot
Cc: Grant Likely, Linus Walleij, linux-kernel@vger.kernel.org
On Friday 22 June 2012 05:18 PM, Alexandre Courbot wrote:
> Commits aca5ce14 and 25553ff0 introduced two new GPIOF_OPEN_DRAIN and
> GPIOF_OPEN_SOURCE flags to gpiolib. Unfortunately they happen to be the
> same as GPIOF_EXPORT and GPIOF_EXPORT_CHANGEABLE, which causes all gpios
> exported at request time to end up open drain and/or open source.
>
> Resolve the conflict by affecting free flags to GPIOF_EXPORT and
> GPIOF_EXPORT_CHANGEABLE.
>
> Signed-off-by: Alexandre Courbot<acourbot@nvidia.com>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
Yes, I have sent similar patch in past.
[PATCH RESEND] gpio: fix bits conflict for gpio flags
Linus W has also Acked it and CCed to stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-22 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-22 11:48 [PATCH] gpio: gpiolib: fix conflicting flag values Alexandre Courbot
2012-06-22 11:52 ` Laxman Dewangan
2012-06-22 12:01 ` Alex Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).