From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Borislav Petkov <borislav.petkov@amd.com>,
Jean Delvare <khali@linux-fr.org>,
x86@kernel.org, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Jan Beulich <JBeulich@suse.com>,
Guenter Roeck <guenter.roeck@ericsson.com>
Subject: Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"
Date: Fri, 22 Jun 2012 11:01:27 -0700 [thread overview]
Message-ID: <4FE4B2F7.9070302@zytor.com> (raw)
In-Reply-To: <20120622065937.GA22167@gmail.com>
On 06/21/2012 11:59 PM, Ingo Molnar wrote:
>
> Plus add a kernel build time check to avoid such string clashes
> in the future? These acronyms tend to be short and hard to read,
> I'd not be surprised if this repeated in the future.
>
Another *MASSIVE* fail is that an x86 cpufeature was added by a patch
that went through the hwmon tree without any x86 maintainer ACK, and
with a subject line that would not have made anyone aware of it:
a4659053 x86/hwmon: fix initialization of coretemp
We maintain x86/cpufeature as a separate -tip branch for a reason:
changes to that stuff mucks with *everything* as it is.
-hpa
next prev parent reply other threads:[~2012-06-22 18:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 14:28 [PATCH] x86, cpufeature: Fix duplicate feature name "dts" Jean Delvare
2012-06-21 16:28 ` H. Peter Anvin
2012-06-21 17:07 ` Jean Delvare
2012-06-21 18:06 ` H. Peter Anvin
2012-06-21 18:44 ` Borislav Petkov
2012-06-21 20:11 ` H. Peter Anvin
2012-06-22 6:59 ` Ingo Molnar
2012-06-22 18:01 ` H. Peter Anvin [this message]
2012-06-22 18:49 ` Guenter Roeck
2012-06-22 7:02 ` Jan Beulich
2012-06-22 13:38 ` H. Peter Anvin
2012-06-22 20:38 ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-24 19:49 ` Jean Delvare
2012-06-24 20:37 ` H. Peter Anvin
2012-06-26 9:13 ` Jean Delvare
2012-06-24 20:39 ` H. Peter Anvin
2012-06-24 20:59 ` H. Peter Anvin
2012-06-22 20:39 ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-25 16:13 ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-25 16:14 ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-26 12:32 ` Jean Delvare
2012-06-26 14:48 ` H. Peter Anvin
2012-06-26 15:20 ` [tip:x86/urgent] x86, cpufeature: Remove stray %s, add -w to mkcapflags.pl tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE4B2F7.9070302@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=borislav.petkov@amd.com \
--cc=guenter.roeck@ericsson.com \
--cc=hpa@linux.intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).