public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Willy Tarreau <w@1wt.eu>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	lwn@lwn.net, Bjorn Helgaas <bhelgaas@google.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: Linux 2.6.32.55
Date: Fri, 22 Jun 2012 23:33:28 +0200	[thread overview]
Message-ID: <4FE4E4A8.1010105@suse.cz> (raw)
In-Reply-To: <20120622211824.GB18996@1wt.eu>

On 06/22/2012 11:18 PM, Willy Tarreau wrote:
>> Given nobody noticed till now, I would incline to drop that patch from
>> 2.6.32 series. Opinions?
> 
> Which one would you drop then ? You got me lost now. I mean, since you've
> been the only one to notice an issue, I have no problem with following you
> on the best way to fix it but I need to understand what you want then :-)

Ok, now I spent some time to look into that.

I thought suse does not need the original patch (PNP: work around Dell
1536/1546 BIOS MMCONFIG bug that breaks USB) as we do not support
CONFIG_AMD_NB. But in 2.6.32.55, it is named CONFIG_K8_NB. So actually
we need it.

There are two problems with the backport:
* missing amd_get_mmconfig_range (added by 24d25dbfa6)
* used wrong names: CONFIG_AMD_NB and asm/amd_nb.h

The latter can be fixed in two ways:
* easier: change CONFIG_AMD_NB to CONFIG_K8_NB and asm/amd_nb.h to
asm/k8.h (obviously, there will be no "upstream commit" for that)
* maybe harder: backport 23ac4ae827 including dependencies (I haven't
looked if there are any)

thanks,
-- 
js
suse labs

  reply	other threads:[~2012-06-22 21:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 22:34 Linux 2.6.32.55 Greg KH
2012-01-25 22:34 ` Greg KH
2012-06-22 19:04 ` Jiri Slaby
2012-06-22 19:38   ` Willy Tarreau
2012-06-22 19:38   ` Greg KH
2012-06-22 21:10     ` Jiri Slaby
2012-06-22 21:18       ` Willy Tarreau
2012-06-22 21:33         ` Jiri Slaby [this message]
2012-06-23 20:57           ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE4E4A8.1010105@suse.cz \
    --to=jslaby@suse.cz \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=stable@vger.kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox