From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Question about the export of symbol lockdep_init_map
Date: Sun, 24 Jun 2012 12:41:01 -0500 [thread overview]
Message-ID: <4FE7512D.2010608@lwfinger.net> (raw)
Ingo,
when you added the locking correctness validator code in commit fbb9ce95, you
exported lockdep_init_map() with EXPORT_SYMBOL_GPL. This choice is causing a
problem with the latest version of Broadcom's hybrid wl driver. Although I do
not agree with their policies regarding drivers with binary blobs, there are
some devices such as the BCM43228 (14e4:4359) for which no open-source driver is
yet available. As a result, owners of such devices are forced to use solutions
such as ndiswrapper, which is worse than using wl.
would you accept the following patch?
Index: wireless-testing/kernel/lockdep.c
===================================================================
--- wireless-testing.orig/kernel/lockdep.c
+++ wireless-testing/kernel/lockdep.c
@@ -2994,7 +2994,7 @@ void lockdep_init_map(struct lockdep_map
if (subclass)
register_lock_class(lock, subclass, 1);
}
-EXPORT_SYMBOL_GPL(lockdep_init_map);
+EXPORT_SYMBOL(lockdep_init_map);
struct lock_class_key __lockdep_no_validate__;
Thanks,
Larry
next reply other threads:[~2012-06-24 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 17:41 Larry Finger [this message]
2012-06-25 11:39 ` Question about the export of symbol lockdep_init_map Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE7512D.2010608@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox