From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Wanpeng Li <liwp.linux@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Balbir Singh <bsingharora@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Mike Frysinger <vapier@gentoo.org>, Arun Sharma <asharma@fb.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit
Date: Tue, 26 Jun 2012 11:45:44 +0900 [thread overview]
Message-ID: <4FE92258.4040900@jp.fujitsu.com> (raw)
In-Reply-To: <20120625110926.GJ19805@tiehlicka.suse.cz>
(2012/06/25 20:09), Michal Hocko wrote:
> On Mon 25-06-12 18:43:57, Wanpeng Li wrote:
>> On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote:
>>> (2012/06/25 17:44), Wanpeng Li wrote:
>>>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>>>
>>>> Optimize memcg_get_hierarchical_limit to save cpu cycle.
>>>>
>>>> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
>>>
>>> I can't understand the benefit of this patch to the real world...
>>>
>>> So, if you wrote the patch description as "clean up" rather than optimize,
>>> ok, I'll agree.
>> OK, I will change to "Cleanup". Thank you Kame.
>
> Does this really clean something up?
>
I just thought unused variable is trash even if it disappears after complie.
Thanks,
-Kame
prev parent reply other threads:[~2012-06-26 2:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 8:44 [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit Wanpeng Li
2012-06-25 9:46 ` Michal Hocko
2012-06-25 9:52 ` Kamezawa Hiroyuki
2012-06-25 10:43 ` Wanpeng Li
2012-06-25 11:09 ` Michal Hocko
2012-06-25 11:19 ` Wanpeng Li
2012-06-26 2:45 ` Kamezawa Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE92258.4040900@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=asharma@fb.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwp.linux@gmail.com \
--cc=mhocko@suse.cz \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox