From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756190Ab2FZEh2 (ORCPT ); Tue, 26 Jun 2012 00:37:28 -0400 Received: from prod-mail-xrelay05.akamai.com ([96.6.114.97]:60959 "EHLO prod-mail-xrelay05.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416Ab2FZEhZ (ORCPT ); Tue, 26 Jun 2012 00:37:25 -0400 Message-ID: <4FE93C83.1020909@akamai.com> Date: Mon, 25 Jun 2012 23:37:23 -0500 From: Josh Hunt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: "James E.J. Bottomley" CC: Josh Hunt , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] scsi: propery initialize atomic_t ioerr_cnt References: <1339250619-1561-1-git-send-email-johunt@akamai.com> In-Reply-To: <1339250619-1561-1-git-send-email-johunt@akamai.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2012 09:03 AM, Josh Hunt wrote: > Initialize atomic_t ioerr_cnt as per the guidelines defined in Documentation/atomic_ops.txt > > Reported-by: Debabrata Banerjee > Signed-off-by: Josh Hunt > --- > drivers/scsi/sd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 6f0a4c6..8b85703 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -2702,6 +2702,7 @@ static int sd_probe(struct device *dev) > sdkp->disk = gd; > sdkp->index = index; > atomic_set(&sdkp->openers, 0); > + atomic_set(&sdkp->device->ioerr_cnt, 0); > > if (!sdp->request_queue->rq_timeout) { > if (sdp->type != TYPE_MOD) Ping? I know these are trivial, but they seem to be correct. If not, I'd be interested to understand why. Thanks Josh