From: Ian Abbott <abbotti@mev.co.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 28/33] staging: comedi: cb_das16_cs: cleanup das16cs_ai_rinsn()
Date: Tue, 26 Jun 2012 10:09:18 +0100 [thread overview]
Message-ID: <4FE97C3E.40508@mev.co.uk> (raw)
In-Reply-To: <201206251717.53025.hartleys@visionengravers.com>
On 2012-06-26 01:17, H Hartley Sweeten wrote:
> @@ -129,7 +124,22 @@ static int das16cs_ai_rinsn(struct comedi_device *dev,
> outw(devpriv->status1, dev->iobase + 4);
>
> devpriv->status2 &= ~0xff00;
> - devpriv->status2 |= range_bits[range];
> + switch (range) {
> + case 0:
> + devpriv->status2 |= 0x800;
> + break;
> + case 1:
> + devpriv->status2 |= 0x000;
> + break;
> + case 2:
> + devpriv->status2 |= 0x100;
> + break;
> + case 3:
> + devpriv->status2 |= 0x200;
> + break;
> + default:
> + return -EINVAL;
> + }
Is that really an improvement? The 'range' variable value will be in
range anyway (the comedi core checks beforehand in
comedi_check_chanlist()), and looking up the constant to OR with
devpriv->status2 is probably less object code (and certainly less source
code).
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-06-26 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 0:17 [PATCH 28/33] staging: comedi: cb_das16_cs: cleanup das16cs_ai_rinsn() H Hartley Sweeten
2012-06-26 9:09 ` Ian Abbott [this message]
2012-06-26 9:15 ` Ian Abbott
2012-06-26 17:10 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE97C3E.40508@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).