From: Wen Congyang <wency@cn.fujitsu.com>
To: lenb@kernel.org, linux-acpi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Yasuaki ISIMATU <isimatu.yasuaki@jp.fujitsu.com>
Subject: [PATCH 5/8] don't print message if request_resource() failed
Date: Tue, 26 Jun 2012 17:21:23 +0800 [thread overview]
Message-ID: <4FE97F13.3000804@cn.fujitsu.com> (raw)
In-Reply-To: <4FE97DD5.6030205@cn.fujitsu.com>
If register_memory_resource() fails, the caller(add_memory()) will
return -EEXIST, and add_memory() returns -EEXIST only when
register_memory_resource() fails. The function acpi_memory_enable_device()
doesn't treat such erro as a fetal error, and don't want this message.
The function that calls add_memory() has printed message if add_memory()
failed, so don't print message in register_memory_resource().
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
mm/memory_hotplug.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 0d7e3ec..2a14d35 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -74,7 +74,6 @@ static struct resource *register_memory_resource(u64 start, u64 size)
res->end = start + size - 1;
res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
if (request_resource(&iomem_resource, res) < 0) {
- printk("System RAM resource %pR cannot be added\n", res);
kfree(res);
res = NULL;
}
--
1.7.1
next prev parent reply other threads:[~2012-06-26 9:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 9:16 [PATCH 0/8] some fixes about acpi_memhotplug Wen Congyang
2012-06-26 9:19 ` [PATCH 1/8] fix memory leak when memory device is unbound from the module acpi_memhotplug Wen Congyang
2012-06-27 4:10 ` David Rientjes
2012-06-26 9:19 ` [PATCH 2/8] free memory device if acpi_memory_enable_device() failed Wen Congyang
2012-06-27 4:12 ` David Rientjes
2012-06-26 9:20 ` [PATCH 3/8] remove memory info from list before freeing it Wen Congyang
2012-06-27 4:15 ` David Rientjes
2012-06-26 9:20 ` [PATCH 4/8] donot allow to eject the memory device if it is being used Wen Congyang
2012-06-27 4:21 ` David Rientjes
2012-06-28 2:01 ` Wen Congyang
2012-06-26 9:21 ` Wen Congyang [this message]
2012-06-27 4:23 ` [PATCH 5/8] don't print message if request_resource() failed David Rientjes
2012-06-28 2:46 ` Wen Congyang
2012-06-26 9:21 ` [PATCH 6/8] bind the memory device when the driver is being loaded Wen Congyang
2012-06-26 15:53 ` Konrad Rzeszutek Wilk
2012-06-27 4:24 ` David Rientjes
2012-06-26 9:22 ` [PATCH 7/8] auto bind the memory device which is hotpluged before the driver is loaded Wen Congyang
2012-06-26 17:06 ` Konrad Rzeszutek Wilk
2012-06-27 4:33 ` David Rientjes
2012-06-26 9:23 ` [PATCH 8/8] release memory resources if hotadd_new_pgdat() failed Wen Congyang
2012-06-27 4:29 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE97F13.3000804@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).