From: Corey Minyard <tcminyard@gmail.com>
To: Srinivas_G_Gowda@Dell.com
Cc: tcminyard@gmail.com, linux-kernel@vger.kernel.org, openipmi@mvista.com
Subject: Re: [PATCH] ipmi: setting OS name as Linux in BMC
Date: Tue, 26 Jun 2012 11:59:17 -0500 [thread overview]
Message-ID: <4FE9EA65.4020005@acm.org> (raw)
In-Reply-To: <4FE9DD1D.9020803@dell.com>
On 06/26/2012 11:02 AM, Srinivas_G_Gowda@Dell.com wrote:
> Corey, Thanks for the comments. I was looking at the way BMC presence
> is detected. Thought it would be appropriate that BMC is told about
> the OS information -- Soon after ipmi_si driver detects
> BMC(Get_Device_ID) and before the driver starts doing anything useful.
> Looked like a quick clean getaway..! Looking at the ipmi_msghandler, I
> don't see how we will be able to do this during the driver
> initialization process. I could probably do it inside
> ipmi_register_smi in ipmi_msghandler. But I still prefer doing this in
> ipmi_si itself. Please let me know your thoughts on this. Thanks, G
The trouble is that there are other interfaces (that are unfortunately
not in the mainstream kernel, but that's a different story) that would
not benefit from this if you put it in ipmi_si. That's a low-level
interface, this is a higher-level function and belongs.
Look at get_guid() called from ipmi_register_smi() in
ipmi_msghandler.c. It's not that hard.
-corey
prev parent reply other threads:[~2012-06-26 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FE9A3EB.50505@dell.com>
2012-06-26 13:24 ` [PATCH] ipmi: setting OS name as Linux in BMC Srinivas_G_Gowda
2012-06-26 13:39 ` Corey Minyard
2012-06-26 16:02 ` Srinivas_G_Gowda
2012-06-26 16:59 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE9EA65.4020005@acm.org \
--to=tcminyard@gmail.com \
--cc=Srinivas_G_Gowda@Dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).