[PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Alex Hung]

According to responses from the BIOS team, ASUS_WMI_METHODID_DSTS2
(0x53545344) will be used as future DSTS ID. In addition, calling
asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL) returns
ASUS_WMI_UNSUPPORTED_METHOD in new ASUS laptop PCs. This patch fixes
no DSTS ID will be assigned in this case.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/platform/x86/asus-wmi.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 25e3093..0f69a97 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -1461,14 +1461,9 @@ static int asus_wmi_platform_init(struct asus_wmi *asus)
 	 */
 	if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS, 0, 0, NULL))
 		asus->dsts_id = ASUS_WMI_METHODID_DSTS;
-	else if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL))
+	else
 		asus->dsts_id = ASUS_WMI_METHODID_DSTS2;
 
-	if (!asus->dsts_id) {
-		pr_err("Can't find DSTS");
-		return -ENODEV;
-	}
-
 	/* CWAP allow to define the behavior of the Fn+F2 key,
 	 * this method doesn't seems to be present on Eee PCs */
 	if (asus->driver->quirks->wapf >= 0)
-- 
1.7.0.4

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Alex Hung]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

Hi All,

The attached is acpi and dmi dumps and dmesg logs of before and after 
applying the patch for references.

Best Regards,
Alex Hung

On 06/20/2012 11:47 AM, Alex Hung wrote:
> According to responses from the BIOS team, ASUS_WMI_METHODID_DSTS2
> (0x53545344) will be used as future DSTS ID. In addition, calling
> asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL) returns
> ASUS_WMI_UNSUPPORTED_METHOD in new ASUS laptop PCs. This patch fixes
> no DSTS ID will be assigned in this case.
>
> Signed-off-by: Alex Hung<alex.hung@canonical.com>
> ---
>   drivers/platform/x86/asus-wmi.c |    7 +------
>   1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 25e3093..0f69a97 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1461,14 +1461,9 @@ static int asus_wmi_platform_init(struct asus_wmi *asus)
>   	 */
>   	if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS, 0, 0, NULL))
>   		asus->dsts_id = ASUS_WMI_METHODID_DSTS;
> -	else if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL))
> +	else
>   		asus->dsts_id = ASUS_WMI_METHODID_DSTS2;
>
> -	if (!asus->dsts_id) {
> -		pr_err("Can't find DSTS");
> -		return -ENODEV;
> -	}
> -
>   	/* CWAP allow to define the behavior of the Fn+F2 key,
>   	 * this method doesn't seems to be present on Eee PCs */
>   	if (asus->driver->quirks->wapf>= 0)


[-- Attachment #2: asus-wmi-dump.tar --]
[-- Type: application/x-tar, Size: 136990 bytes --]

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Jonathan Nieder]

Hi Alex,

Alex Hung wrote:

> According to responses from the BIOS team, ASUS_WMI_METHODID_DSTS2
> (0x53545344) will be used as future DSTS ID. In addition, calling
> asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL) returns
> ASUS_WMI_UNSUPPORTED_METHOD in new ASUS laptop PCs. This patch fixes
> no DSTS ID will be assigned in this case.

 Tested-by: Carsten Otto <otto@informatik.rwth-aachen.de> # 3.2.21, Asus UX31A

More precisely, Carsten was unable to use asus_wmi, getting the
following message from a distro kernel based on 3.4.1 and from
unpatched 3.2.21:[1]

| asus_wmi: Can't find DSTS

After applying the patch described above to 3.2.21, multimedia keys
work.

| The patch works, dmesg before and after are attached.
|
| With the patched kernel I can (at least) change the volume using the
| Fn keys, gnome shows some audio related icons and a changing (volume)
| bar. I did not try further than that (yet).

This is on an Asus Zenbook Prime (UX31A).  acpidump, logs, and other
info are at [1].  Could you remind me when this hits mainline so we
can make sure it gets applied to earlier kernels, for example by
adding "Cc: stable@vger.kernel.org" to the commit message?

Thanks and hope that helps,
Jonathan

[1] http://bugs.debian.org/679158

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Carsten Otto]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Dear all,

On Tue, Jun 26, 2012 at 04:39:58PM -0500, Jonathan Nieder wrote:
> After applying the patch described above to 3.2.21, multimedia keys
> work.

To be precise, only some of the Fn keys work. I will update the
bug report at http://bugs.debian.org/679158 now. Please contact me if
you need further information,

Best regards,
-- 
Carsten Otto           otto@informatik.rwth-aachen.de
LuFG Informatik 2      http://verify.rwth-aachen.de/otto/
RWTH Aachen            phone: +49 241 80-21211

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Alex Hung]

On 06/27/2012 05:58 AM, Carsten Otto wrote:
> Dear all,
>
> On Tue, Jun 26, 2012 at 04:39:58PM -0500, Jonathan Nieder wrote:
>> After applying the patch described above to 3.2.21, multimedia keys
>> work.
>
> To be precise, only some of the Fn keys work. I will update the
> bug report at http://bugs.debian.org/679158 now. Please contact me if
> you need further information,
>
> Best regards,

Some Fn keys fail to work is probably the result of un-handled events, 
i.e. asus_wmi: Unknown key 7a pressed.

Do you always receive the error messages for each of the Fn-keys that 
fails? I can take a closer look and try to fix each of them. I don't 
have a Asus Zenbook Prime but I can check on other available Asus machines.

Best Regards,
Alex Hung

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Jonathan Nieder]

Hi Alex,

Alex Hung wrote:

> Some Fn keys fail to work is probably the result of un-handled
> events, i.e. asus_wmi: Unknown key 7a pressed.
>
> Do you always receive the error messages for each of the Fn-keys
> that fails? I can take a closer look and try to fix each of them. I
> don't have a Asus Zenbook Prime but I can check on other available
> Asus machines.

It looks like your message didn't reach Carsten.  I'm cc-ing him now.

See http://bugs.debian.org/679158#62 for a summary of what each Fn-key
that fails does (it varies from key to key).

Regards,
Jonathan

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Carsten Otto]

[-- Attachment #1.1: Type: text/plain, Size: 841 bytes --]

Hi,

On Wed, Jun 27, 2012 at 05:17:43PM -0500, Jonathan Nieder wrote:
> It looks like your message didn't reach Carsten.  I'm cc-ing him now.

Thanks, where did the original message go? :)

> See http://bugs.debian.org/679158#62 for a summary of what each Fn-key
> that fails does (it varies from key to key).

That list is correct. To clarify, the "Unknown key 7a pressed" message
only appears with Fn+A.

According to the following thread, some Ubuntu users managed to get more
buttons to work. The test module/program/? can be downloaded from #49
and #30 (I attached the files).

http://ubuntuforums.org/showthread.php?t=2005756&page=5

Best regards,
-- 
Carsten Otto           otto@informatik.rwth-aachen.de
LuFG Informatik 2      http://verify.rwth-aachen.de/otto/
RWTH Aachen            phone: +49 241 80-21211

[-- Attachment #1.2: asus-wmi-dkms_0.2_all.deb.gz --]
[-- Type: application/octet-stream, Size: 30033 bytes --]

[-- Attachment #1.3: asus-wmi-dkms_999.01_all.deb.gz --]
[-- Type: application/octet-stream, Size: 29484 bytes --]

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Corentin Chary]

On Wed, Jun 20, 2012 at 5:47 AM, Alex Hung <alex.hung@canonical.com> wrote:
> According to responses from the BIOS team, ASUS_WMI_METHODID_DSTS2
> (0x53545344) will be used as future DSTS ID. In addition, calling
> asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL) returns
> ASUS_WMI_UNSUPPORTED_METHOD in new ASUS laptop PCs. This patch fixes
> no DSTS ID will be assigned in this case.
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/platform/x86/asus-wmi.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 25e3093..0f69a97 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1461,14 +1461,9 @@ static int asus_wmi_platform_init(struct asus_wmi *asus)
>         */
>        if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS, 0, 0, NULL))
>                asus->dsts_id = ASUS_WMI_METHODID_DSTS;
> -       else if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL))
> +       else
>                asus->dsts_id = ASUS_WMI_METHODID_DSTS2;
>
> -       if (!asus->dsts_id) {
> -               pr_err("Can't find DSTS");
> -               return -ENODEV;
> -       }
> -
>        /* CWAP allow to define the behavior of the Fn+F2 key,
>         * this method doesn't seems to be present on Eee PCs */
>        if (asus->driver->quirks->wapf >= 0)
> --
> 1.7.0.4
>

Hum, I don't like acking patches referencing documentation I can't
read, but I don't really have the choice !

Matthew, could you merge this one ?
Thanks,

Acked-By: Corentin Chary <corentin.chary@gmail.com>


-- 
Corentin Chary
http://xf.iksaif.net

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Carsten Otto]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

Dear all,

the patch seems to be integrated in 3.5.4 (current stable kernel). When
rebasing using git I see that the patch is not applied on top, most
likely because it was already included somewhere in the official stable
Linux itself.

As mentioned in the following Ubuntu bug report, this patch causes
problems (which I also observe).
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1041883

It takes me about 10 tries to successfully boot my system. In the
unsuccessful tries the screen is blanked shortly during the boot process
and nothing happens (the magic keys don't work, network access cannot be
tested that early).

Bye,
-- 
Carsten Otto           otto@informatik.rwth-aachen.de
LuFG Informatik 2      http://verify.rwth-aachen.de/otto/
RWTH Aachen            phone: +49 241 80-21211

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] asus-wmi: use ASUS_WMI_METHODID_DSTS2 as default DSTS ID.

[Corentin Chary]

Hi,

On Tue, Sep 18, 2012 at 11:21 AM, Carsten Otto
<otto@informatik.rwth-aachen.de> wrote:
> Dear all,
>
> the patch seems to be integrated in 3.5.4 (current stable kernel). When
> rebasing using git I see that the patch is not applied on top, most
> likely because it was already included somewhere in the official stable
> Linux itself.

Easy workaround is to blacklist/remove asus-wmi (and/or
eeepc-wmi/asus-nb-wmi). I think ubuntu guys are working on it, and
since they seems to be working with Asus (and I'm not), it will be
easier for them.

> As mentioned in the following Ubuntu bug report, this patch causes
> problems (which I also observe).
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1041883
>
> It takes me about 10 tries to successfully boot my system. In the
> unsuccessful tries the screen is blanked shortly during the boot process
> and nothing happens (the magic keys don't work, network access cannot be
> tested that early).
>
> Bye,
> --
> Carsten Otto           otto@informatik.rwth-aachen.de
> LuFG Informatik 2      http://verify.rwth-aachen.de/otto/
> RWTH Aachen            phone: +49 241 80-21211
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
>
> iEYEARECAAYFAlBYSzUACgkQjUF4jpCSQBQpbgCfSUUvaZbs1krkcRKa8iTcyKxA
> 7AQAn1NfXugZ5553+Z9LOB46lJqFcXt8
> =avwS
> -----END PGP SIGNATURE-----
>



-- 
Corentin Chary
http://xf.iksaif.net