From: Dmitry Antipov <dmitry.antipov@linaro.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH] perf sched replay: fix event lookup
Date: Wed, 27 Jun 2012 13:18:17 +0400 [thread overview]
Message-ID: <4FEACFD9.7020503@linaro.org> (raw)
In-Reply-To: <20120625232016.GA28525@infradead.org>
On 06/26/2012 03:20 AM, Arnaldo Carvalho de Melo wrote:
>
>> Fair enough. The method should be a simple wrapper to libtraceevent APIs
>> like this patch.
>
> The pevent thing is per perf.data file, so I made it stop being static
> and become a perf_session member, so tools processing perf.data files
> use perf_session and _there_ we read the event into session->pevent and
> then have to change everywhere to stop using that single global pevent
> variable and use the per session one.
>
> Dmitry, can you test the attached patch to check if it solves the
> problems you reported?
This looks good and works for my x86 <-> ARM tests.
> Note that it _doesn't_ fall backs to trace__event_id, as we're not
> interested at all in what is present in the
> /sys/kernel/debug/tracing/events in the workstation doing the analysis,
> just in what is in the perf.data file.
Agree.
Dmitry
next prev parent reply other threads:[~2012-06-27 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 9:05 [PATCH] perf sched replay: fix event lookup Dmitry Antipov
2012-06-11 5:46 ` Namhyung Kim
2012-06-11 14:08 ` Arnaldo Carvalho de Melo
2012-06-12 6:01 ` Namhyung Kim
2012-06-12 17:11 ` Arnaldo Carvalho de Melo
2012-06-25 23:20 ` Arnaldo Carvalho de Melo
2012-06-27 9:18 ` Dmitry Antipov [this message]
2012-06-27 14:21 ` Arnaldo Carvalho de Melo
2012-06-29 16:17 ` [tip:perf/core] perf tools: Stop using a global trace events description list tip-bot for Arnaldo Carvalho de Melo
2012-06-25 18:02 ` [PATCH] perf sched replay: fix event lookup Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEACFD9.7020503@linaro.org \
--to=dmitry.antipov@linaro.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=amit.kucheria@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox