Re: [PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[Stephen Clark <sclark46@earthlink.net>]

On 06/26/2012 08:45 PM, H Hartley Sweeten wrote:
> Cleanup the cb_pcidas driver.
>
> H Hartley Sweeten (36):
>    staging: comedi: cb_pcidas: remove forward declarations 1
>    staging: comedi: cb_pcidas: remove forward declarations 2
>    staging: comedi: cb_pcidas: remove forward declarations 3
>    staging: comedi: cb_pcidas: remove forward declarations 4
>    staging: comedi: cb_pcidas: remove forward declarations 5
>    staging: comedi: cb_pcidas: remove forward declarations 6
>    staging: comedi: cb_pcidas: remove forward declarations 7
>    staging: comedi: cb_pcidas: remove forward declarations 8
>    staging: comedi: cb_pcidas: remove forward declarations 9
>    staging: comedi: cb_pcidas: remove thisboard and devpriv macros
>    staging: comedi: cb_pcidas: factor out the find pci device code
>    staging: comedi: cb_pcidas: remove some obvious comments in the
>      attach
>    staging: comedi: cb_pcidas: remove the PCI BAR index defines
>    staging: comedi: cb_pcidas: remove CB_PCIDAS_DEBUG define
>    staging: comedi: cb_pcidas: remove unused io region size defines
>    staging: comedi: cb_pcidas: simplify the boardinfo
>    staging: comedi: cb_pcidas: cleanup the boardinfo 1
>    staging: comedi: cb_pcidas: cleanup the boardinfo 2
>    staging: comedi: cb_pcidas: cleanup the boardinfo 3
>    staging: comedi: cb_pcidas: cleanup the boardinfo 4
>    staging: comedi: cb_pcidas: cleanup ai_config_insn()
>    staging: comedi: cb_pcidas: move the "find pci" dev_printk messages
>    staging: comedi: cb_pcidas: use the driver_name for the resource name
>    staging: comedi: cb_pcidas: check for failure of subdev_8255_init
>    staging: comedi: cb_pcidas: fix a space before tab issue
>    staging: comedi: cb_pcidas: fix some>  80 char lines
>    staging: comedi: cb_pcidas: fix comments in *_cmdtest functions
>    staging: comedi: cb_pcidas: remove 'volatile' on private data
>      variables
>    staging: comedi: cb_pcidas: fix comments in private data struct
>    staging: comedi: cb_pcidas: change dac bit enums into defines
>    staging: comedi: cb_pcidas: add whitespace to all the #define's
>    staging: comedi: cb_pcidas: fix remaining checkpatch.pl issues
>    staging: comedi: cb_pcidas: cleanup cb_pcidas_ao_fifo_winsn()
>    staging: comedi: cb_pcidas: cleanup cb_pcidas_ao_nofifo_winsn()
>    staging: comedi: cb_pcidas: cleanup cb_pcidas_ai_rinsn()
>    staging: comedi: cb_pcidas: cleanup dac08_write()
>
>   drivers/staging/comedi/drivers/cb_pcidas.c | 1695 +++++++++++++---------------
>   1 file changed, 770 insertions(+), 925 deletions(-)
>
>    
I there some reason you can't post these as response to this message, 
like GKH does, so if readers aren't
interested they can mark the thread read without stepping thru each patch.

-- 

"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty
decreases."  (Thomas Jefferson)