[PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[H Hartley Sweeten]

Cleanup the cb_pcidas driver.

H Hartley Sweeten (36):
  staging: comedi: cb_pcidas: remove forward declarations 1
  staging: comedi: cb_pcidas: remove forward declarations 2
  staging: comedi: cb_pcidas: remove forward declarations 3
  staging: comedi: cb_pcidas: remove forward declarations 4
  staging: comedi: cb_pcidas: remove forward declarations 5
  staging: comedi: cb_pcidas: remove forward declarations 6
  staging: comedi: cb_pcidas: remove forward declarations 7
  staging: comedi: cb_pcidas: remove forward declarations 8
  staging: comedi: cb_pcidas: remove forward declarations 9
  staging: comedi: cb_pcidas: remove thisboard and devpriv macros
  staging: comedi: cb_pcidas: factor out the find pci device code
  staging: comedi: cb_pcidas: remove some obvious comments in the
    attach
  staging: comedi: cb_pcidas: remove the PCI BAR index defines
  staging: comedi: cb_pcidas: remove CB_PCIDAS_DEBUG define
  staging: comedi: cb_pcidas: remove unused io region size defines
  staging: comedi: cb_pcidas: simplify the boardinfo
  staging: comedi: cb_pcidas: cleanup the boardinfo 1
  staging: comedi: cb_pcidas: cleanup the boardinfo 2
  staging: comedi: cb_pcidas: cleanup the boardinfo 3
  staging: comedi: cb_pcidas: cleanup the boardinfo 4
  staging: comedi: cb_pcidas: cleanup ai_config_insn()
  staging: comedi: cb_pcidas: move the "find pci" dev_printk messages
  staging: comedi: cb_pcidas: use the driver_name for the resource name
  staging: comedi: cb_pcidas: check for failure of subdev_8255_init
  staging: comedi: cb_pcidas: fix a space before tab issue
  staging: comedi: cb_pcidas: fix some > 80 char lines
  staging: comedi: cb_pcidas: fix comments in *_cmdtest functions
  staging: comedi: cb_pcidas: remove 'volatile' on private data
    variables
  staging: comedi: cb_pcidas: fix comments in private data struct
  staging: comedi: cb_pcidas: change dac bit enums into defines
  staging: comedi: cb_pcidas: add whitespace to all the #define's
  staging: comedi: cb_pcidas: fix remaining checkpatch.pl issues
  staging: comedi: cb_pcidas: cleanup cb_pcidas_ao_fifo_winsn()
  staging: comedi: cb_pcidas: cleanup cb_pcidas_ao_nofifo_winsn()
  staging: comedi: cb_pcidas: cleanup cb_pcidas_ai_rinsn()
  staging: comedi: cb_pcidas: cleanup dac08_write()

 drivers/staging/comedi/drivers/cb_pcidas.c | 1695 +++++++++++++---------------
 1 file changed, 770 insertions(+), 925 deletions(-)

-- 
1.7.11

Re: [PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[Stephen Clark]

On 06/26/2012 08:45 PM, H Hartley Sweeten wrote:
> Cleanup the cb_pcidas driver.
>
> H Hartley Sweeten (36):
>    staging: comedi: cb_pcidas: remove forward declarations 1
>    staging: comedi: cb_pcidas: remove forward declarations 2
>    staging: comedi: cb_pcidas: remove forward declarations 3
>    staging: comedi: cb_pcidas: remove forward declarations 4
>    staging: comedi: cb_pcidas: remove forward declarations 5
>    staging: comedi: cb_pcidas: remove forward declarations 6
>    staging: comedi: cb_pcidas: remove forward declarations 7
>    staging: comedi: cb_pcidas: remove forward declarations 8
>    staging: comedi: cb_pcidas: remove forward declarations 9
>    staging: comedi: cb_pcidas: remove thisboard and devpriv macros
>    staging: comedi: cb_pcidas: factor out the find pci device code
>    staging: comedi: cb_pcidas: remove some obvious comments in the
>      attach
>    staging: comedi: cb_pcidas: remove the PCI BAR index defines
>    staging: comedi: cb_pcidas: remove CB_PCIDAS_DEBUG define
>    staging: comedi: cb_pcidas: remove unused io region size defines
>    staging: comedi: cb_pcidas: simplify the boardinfo
>    staging: comedi: cb_pcidas: cleanup the boardinfo 1
>    staging: comedi: cb_pcidas: cleanup the boardinfo 2
>    staging: comedi: cb_pcidas: cleanup the boardinfo 3
>    staging: comedi: cb_pcidas: cleanup the boardinfo 4
>    staging: comedi: cb_pcidas: cleanup ai_config_insn()
>    staging: comedi: cb_pcidas: move the "find pci" dev_printk messages
>    staging: comedi: cb_pcidas: use the driver_name for the resource name
>    staging: comedi: cb_pcidas: check for failure of subdev_8255_init
>    staging: comedi: cb_pcidas: fix a space before tab issue
>    staging: comedi: cb_pcidas: fix some>  80 char lines
>    staging: comedi: cb_pcidas: fix comments in *_cmdtest functions
>    staging: comedi: cb_pcidas: remove 'volatile' on private data
>      variables
>    staging: comedi: cb_pcidas: fix comments in private data struct
>    staging: comedi: cb_pcidas: change dac bit enums into defines
>    staging: comedi: cb_pcidas: add whitespace to all the #define's
>    staging: comedi: cb_pcidas: fix remaining checkpatch.pl issues
>    staging: comedi: cb_pcidas: cleanup cb_pcidas_ao_fifo_winsn()
>    staging: comedi: cb_pcidas: cleanup cb_pcidas_ao_nofifo_winsn()
>    staging: comedi: cb_pcidas: cleanup cb_pcidas_ai_rinsn()
>    staging: comedi: cb_pcidas: cleanup dac08_write()
>
>   drivers/staging/comedi/drivers/cb_pcidas.c | 1695 +++++++++++++---------------
>   1 file changed, 770 insertions(+), 925 deletions(-)
>
>    
I there some reason you can't post these as response to this message, 
like GKH does, so if readers aren't
interested they can mark the thread read without stepping thru each patch.

-- 

"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty
decreases."  (Thomas Jefferson)

RE: [PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[H Hartley Sweeten]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 508 bytes --]

On Wednesday, June 27, 2012 9:31 AM, Stephen Clark wrote:
> I there some reason you can't post these as response to this message, 
> like GKH does, so if readers aren't
> interested they can mark the thread read without stepping thru each patch.

The only reason is, I'm not sure how to do that... ;-)

Greg, any pointers on how?

Thanks,
Hartley

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[Ian Abbott]

On 2012-06-27 17:45, H Hartley Sweeten wrote:
> On Wednesday, June 27, 2012 9:31 AM, Stephen Clark wrote:
>> I there some reason you can't post these as response to this message,
>> like GKH does, so if readers aren't
>> interested they can mark the thread read without stepping thru each patch.
>
> The only reason is, I'm not sure how to do that... ;-)
>
> Greg, any pointers on how?

The easiest way is to use the --compose option of git send-email, which 
lets you edit an introductory email to the patch series you are posting 
and uses that email's ID as the --in-reply-to for all the following 
patch emails (assuming you don't have --chain-reply-to set).

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

Re: [PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

[gregkh]

On Wed, Jun 27, 2012 at 06:02:34PM +0100, Ian Abbott wrote:
> On 2012-06-27 17:45, H Hartley Sweeten wrote:
> >On Wednesday, June 27, 2012 9:31 AM, Stephen Clark wrote:
> >>I there some reason you can't post these as response to this message,
> >>like GKH does, so if readers aren't
> >>interested they can mark the thread read without stepping thru each patch.
> >
> >The only reason is, I'm not sure how to do that... ;-)
> >
> >Greg, any pointers on how?
> 
> The easiest way is to use the --compose option of git send-email,
> which lets you edit an introductory email to the patch series you
> are posting and uses that email's ID as the --in-reply-to for all
> the following patch emails (assuming you don't have --chain-reply-to
> set).

Yes, that's the easiest way to do this, and is what I recommend.

greg k-h