From: Wen Congyang <wency@cn.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yasuaki ISIMATU <isimatu.yasuaki@jp.fujitsu.com>
Subject: Re: [PATCH 4/8] donot allow to eject the memory device if it is being used
Date: Thu, 28 Jun 2012 10:01:26 +0800 [thread overview]
Message-ID: <4FEBBAF6.60409@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206262118070.24245@chino.kir.corp.google.com>
At 06/27/2012 12:21 PM, David Rientjes Wrote:
> On Tue, 26 Jun 2012, Wen Congyang wrote:
>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index a325bb9..2e5d5ab 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -78,6 +78,7 @@ struct acpi_memory_info {
>> unsigned short caching; /* memory cache attribute */
>> unsigned short write_protect; /* memory read/write attribute */
>> unsigned int enabled:1;
>> + unsigned int failed:1;
>> };
>>
>> struct acpi_memory_device {
>> @@ -251,9 +252,19 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>> node = memory_add_physaddr_to_nid(info->start_addr);
>>
>> result = add_memory(node, info->start_addr, info->length);
>> - if (result)
>> +
>> + /*
>> + * If the memory block has been used by the kernel, add_memory()
>> + * returns -EEXIST. If add_memory() returns the other error, it
>> + * means that this memory block is not used by the kernel.
>> + */
>> + if (result && result != -EEXIST) {
>> + info->failed = 1;
>> continue;
>> - info->enabled = 1;
>> + }
>> +
>> + if (!result)
>> + info->enabled = 1;
>> num_enabled++;
>> }
>> if (!num_enabled) {
>
> num_enabled should only be incremented for result == 0.
>
If num_enabled is not incremented for result == -EEXIST, this device is not
managed by this module, and it is not able to be hot removed. Another problem
is the user will see a strange message: add_memory failed
Thanks
Wen Congyang
next prev parent reply other threads:[~2012-06-28 1:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 9:16 [PATCH 0/8] some fixes about acpi_memhotplug Wen Congyang
2012-06-26 9:19 ` [PATCH 1/8] fix memory leak when memory device is unbound from the module acpi_memhotplug Wen Congyang
2012-06-27 4:10 ` David Rientjes
2012-06-26 9:19 ` [PATCH 2/8] free memory device if acpi_memory_enable_device() failed Wen Congyang
2012-06-27 4:12 ` David Rientjes
2012-06-26 9:20 ` [PATCH 3/8] remove memory info from list before freeing it Wen Congyang
2012-06-27 4:15 ` David Rientjes
2012-06-26 9:20 ` [PATCH 4/8] donot allow to eject the memory device if it is being used Wen Congyang
2012-06-27 4:21 ` David Rientjes
2012-06-28 2:01 ` Wen Congyang [this message]
2012-06-26 9:21 ` [PATCH 5/8] don't print message if request_resource() failed Wen Congyang
2012-06-27 4:23 ` David Rientjes
2012-06-28 2:46 ` Wen Congyang
2012-06-26 9:21 ` [PATCH 6/8] bind the memory device when the driver is being loaded Wen Congyang
2012-06-26 15:53 ` Konrad Rzeszutek Wilk
2012-06-27 4:24 ` David Rientjes
2012-06-26 9:22 ` [PATCH 7/8] auto bind the memory device which is hotpluged before the driver is loaded Wen Congyang
2012-06-26 17:06 ` Konrad Rzeszutek Wilk
2012-06-27 4:33 ` David Rientjes
2012-06-26 9:23 ` [PATCH 8/8] release memory resources if hotadd_new_pgdat() failed Wen Congyang
2012-06-27 4:29 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEBBAF6.60409@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).