From: Wen Congyang <wency@cn.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yasuaki ISIMATU <isimatu.yasuaki@jp.fujitsu.com>
Subject: Re: [PATCH 5/8] don't print message if request_resource() failed
Date: Thu, 28 Jun 2012 10:46:20 +0800 [thread overview]
Message-ID: <4FEBC57C.20302@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206262122160.24245@chino.kir.corp.google.com>
At 06/27/2012 12:23 PM, David Rientjes Wrote:
> On Tue, 26 Jun 2012, Wen Congyang wrote:
>
>> If register_memory_resource() fails, the caller(add_memory()) will
>> return -EEXIST, and add_memory() returns -EEXIST only when
>> register_memory_resource() fails. The function acpi_memory_enable_device()
>> doesn't treat such erro as a fetal error, and don't want this message.
>> The function that calls add_memory() has printed message if add_memory()
>> failed, so don't print message in register_memory_resource().
>>
>
> That may be true for acpi_memory_enable_device(), but have you checked
> other callers to add_memory()?
>
There are four functions that call add_memory():
1. acpi_memory_enable_device()
2. memory_probe_store()
This caller is the callback of system call write. The user can get the return
value by errno.
3. add_memory_merged()
This caller does not check the return value. I guess add_memory() always
successes in this place.
4. bp_state reserve_additional_memory()
This caller prints message if add_memory() failed.
So I think we can remove this message...
Thanks
Wen Congyang
next prev parent reply other threads:[~2012-06-28 2:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 9:16 [PATCH 0/8] some fixes about acpi_memhotplug Wen Congyang
2012-06-26 9:19 ` [PATCH 1/8] fix memory leak when memory device is unbound from the module acpi_memhotplug Wen Congyang
2012-06-27 4:10 ` David Rientjes
2012-06-26 9:19 ` [PATCH 2/8] free memory device if acpi_memory_enable_device() failed Wen Congyang
2012-06-27 4:12 ` David Rientjes
2012-06-26 9:20 ` [PATCH 3/8] remove memory info from list before freeing it Wen Congyang
2012-06-27 4:15 ` David Rientjes
2012-06-26 9:20 ` [PATCH 4/8] donot allow to eject the memory device if it is being used Wen Congyang
2012-06-27 4:21 ` David Rientjes
2012-06-28 2:01 ` Wen Congyang
2012-06-26 9:21 ` [PATCH 5/8] don't print message if request_resource() failed Wen Congyang
2012-06-27 4:23 ` David Rientjes
2012-06-28 2:46 ` Wen Congyang [this message]
2012-06-26 9:21 ` [PATCH 6/8] bind the memory device when the driver is being loaded Wen Congyang
2012-06-26 15:53 ` Konrad Rzeszutek Wilk
2012-06-27 4:24 ` David Rientjes
2012-06-26 9:22 ` [PATCH 7/8] auto bind the memory device which is hotpluged before the driver is loaded Wen Congyang
2012-06-26 17:06 ` Konrad Rzeszutek Wilk
2012-06-27 4:33 ` David Rientjes
2012-06-26 9:23 ` [PATCH 8/8] release memory resources if hotadd_new_pgdat() failed Wen Congyang
2012-06-27 4:29 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEBC57C.20302@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).