Re: [PATCH] pwm-backlight: add regulator and GPIO support

Alex Courbot
2012-07-05T06:23:54Z

On 07/05/2012 03:20 PM, Sascha Hauer wrote:
>> Oh, that is a mistake of mine then. Driver probe should continue if
>> no regulator is declared (but should fail if some other error
>> occured). I want to maintain backward compatibility with current
>> users of the driver, so regulator/gpio specification should be
>> optional.
>
> I think the only way doing this is to add a flag to platform_data. I
> don't know if that's accepted though.

I thought about just checking if devm_get_regulator returned -ENODEV and
happily continue if that was the case, assuming no regulator was declared.

But anyway with the power sequences specification this problem becomes
null, since regulators will have to be explicitly declared anyway. I
might be flamed for putting a parser and interpreter into a backlight
driver, but I'll take my chances. :)

Alex.