From: Li Zefan <lizefan@huawei.com>
To: "tj@kernel.org" <tj@kernel.org>
Cc: shyju pv <shyju.pv@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Sanil kumar <sanil.kumar@huawei.com>,
Masanari Iida <standby24x7@gmail.com>
Subject: Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]
Date: Sat, 30 Jun 2012 14:13:02 +0800 [thread overview]
Message-ID: <4FEE98EE.1050409@huawei.com> (raw)
In-Reply-To: <20120629165809.GB21048@google.com>
On 2012/6/30 0:58, tj@kernel.org wrote:
> Hey,
>
> On Fri, Jun 29, 2012 at 10:20:11AM +0800, Li Zefan wrote:
>>> Can you please elaborate a bit? I'm not really following? Where does
>>> the last root->d_count-- come from?
>>
>>
>> From my limited knowledge about vfs internal, seems the parent's refcnt won't go down
>> to 0 before its children. When mkdir, the parent's refcnt will be incremented, and
>> after rmdir, dput(subdir) will drop subdir's refcnt and then drop parent's.
>>
>> So when dropping the subdir's refcnt and leading the superblock to be killed, the root's
>> dentry is still > 0.
>
> Heh, yeah, I thought you found who was holding out on the refcnt. :)
>
dput will drop both the subdir and the root's dentry refcnt, but kill_sb will be called
inbetween.
So it's bad to have dentry refcnts dangling after umount. I've made a patch so css will
pin cgroup instead of cgroup dentry.
next prev parent reply other threads:[~2012-06-30 6:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 19:08 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup] shyju pv
2012-06-26 23:00 ` Masanari Iida
2012-06-27 18:29 ` tj
2012-06-27 23:02 ` tj
2012-06-28 14:09 ` Masanari Iida
2012-06-28 6:07 ` Li Zefan
2012-06-28 6:07 ` Li Zefan
2012-06-28 18:07 ` tj
2012-06-29 2:20 ` Li Zefan
2012-06-29 16:58 ` tj
2012-06-29 18:07 ` Masanari Iida
2012-06-30 6:13 ` Li Zefan [this message]
2012-06-30 6:47 ` Al Viro
2012-06-30 7:04 ` Tejun Heo
2012-06-30 8:34 ` Al Viro
2012-07-03 17:10 ` Tejun Heo
2012-07-03 17:38 ` [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode Tejun Heo
2012-07-04 5:40 ` Li Zefan
2012-07-09 17:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEE98EE.1050409@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanil.kumar@huawei.com \
--cc=shyju.pv@huawei.com \
--cc=standby24x7@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).