From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932468Ab2GBTqo (ORCPT ); Mon, 2 Jul 2012 15:46:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24181 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429Ab2GBTqn (ORCPT ); Mon, 2 Jul 2012 15:46:43 -0400 Message-ID: <4FF1FA95.7000404@redhat.com> Date: Mon, 02 Jul 2012 15:46:29 -0400 From: Adam Jackson User-Agent: Mozilla/12.0.1 MIME-Version: 1.0 To: Takashi Iwai CC: Sven Joachim , dri-devel@lists.freedesktop.org, Rodrigo Vivi , Dave Airlie , linux-kernel@vger.kernel.org Subject: Re: Bogus video resolution in Linux 3.5-rc4 References: <874npzebev.fsf@turtle.gmx.de> <87obo7jnmn.fsf@turtle.gmx.de> <87r4t3w59r.fsf@turtle.gmx.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/26/12 3:21 AM, Takashi Iwai wrote: > From: Takashi Iwai > Subject: [PATCH] drm: edid: Don't add inferred modes with higher resolution > > When a monitor EDID doesn't give the preferred bit, driver assumes > that the mode with the higest resolution and rate is the preferred > mode. Meanwhile the recent changes for allowing more modes in the > GFT/CVT ranges give actually more modes, and some modes may be over > the native size. Thus such a mode would be picked up as the preferred > mode although it's no native resolution. > > For avoiding such a problem, this patch limits the addition of > inferred modes by checking not to be greater than other modes. > Also, it checks the duplicated mode entry at the same time. This is a little aggressive on CRTs, but whatever, better than what's there. Reviewed-by: Adam Jackson - ajax