From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757516Ab2GDDRT (ORCPT ); Tue, 3 Jul 2012 23:17:19 -0400 Received: from va3ehsobe002.messaging.microsoft.com ([216.32.180.12]:7247 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756016Ab2GDDRQ convert rfc822-to-8bit (ORCPT ); Tue, 3 Jul 2012 23:17:16 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: 0 X-BigFish: VS0(zz98dIzz1202hzzz2dh2a8h668h839h8e2h8e3hd25he5bhf0ahbe9i) From: Tabi Timur-B04825 To: Zhao Chenhui-B35336 CC: Zhao Chenhui-B35336 , "linuxppc-dev@lists.ozlabs.org" , Wood Scott-B07421 , "galak@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , Li Yang-R58472 Subject: Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync Thread-Topic: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync Thread-Index: AQHNWRnaavpowtpO5UeeCNsHPM8rhJcYx9kAgAAAxAA= Date: Wed, 4 Jul 2012 03:17:12 +0000 Message-ID: <4FF3B5B6.8090400@freescale.com> References: <1341310879-5468-1-git-send-email-chenhui.zhao@freescale.com> <20120704031426.GA6133@localhost.localdomain> In-Reply-To: <20120704031426.GA6133@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120615 Firefox/13.0.1 SeaMonkey/2.10.1 x-originating-ip: [70.112.118.223] Content-Type: text/plain; charset=US-ASCII Content-ID: Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhao Chenhui wrote: > If the guts variable is NULL, it indicates there is error in dts or kernel. > We should fix the error, rather than ignore it. And that's why there's a warning message. Crashing the kernel is not going to fix anything. > Moreover, if smp_85xx_ops.give/take_timebase is NULL, kernel can not do the timebase sync. Is that necessary for the kernel to boot? -- Timur Tabi Linux kernel developer at Freescale