From: Alex Courbot <acourbot@nvidia.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] pwm-backlight: add regulator and GPIO support
Date: Thu, 5 Jul 2012 00:14:39 +0900 [thread overview]
Message-ID: <4FF45DDF.9000306@nvidia.com> (raw)
In-Reply-To: <20120704130056.GC30009@pengutronix.de>
On Wed 04 Jul 2012 10:00:56 PM JST, Sascha Hauer wrote:
>> That's very bad indeed. I assumed that the kernel would free
>> devm-allocated resources after probe returned -EPROBE_DEFER,
>
> It indeed does free devm allocated resources, but neither the gpio nor
> the pwm are devm allocated.
As far as I can tell the gpio is allocated through devm as well:
> + ret = devm_gpio_request_one(&pdev->dev, data->enable_gpio,
> + GPIOF_OUT_INIT_HIGH, "backlight_enable");
Thus if it is not reclaimed with probe returns with -EPROBE_DEFER, then
I guess something is going wrong elsewhere. You are right that the PWM
should be freed by the driver thought.
> Also please be aware that using a regulator in the pwm backlight will
> instantly break all existing users. That's hardly your fault though.
Sorry, I don't see why. Could you elaborate on this?
Thanks,
Alex.
next prev parent reply other threads:[~2012-07-04 15:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 13:22 [PATCH] pwm-backlight: add regulator and GPIO support Alexandre Courbot
2012-06-29 16:04 ` Stephen Warren
2012-06-30 3:54 ` Alex Courbot
2012-06-30 18:37 ` Thierry Reding
2012-07-02 3:35 ` Alexandre Courbot
2012-07-02 6:46 ` Thierry Reding
2012-07-02 7:18 ` Alexandre Courbot
2012-07-04 10:48 ` Sascha Hauer
2012-07-04 12:26 ` Alex Courbot
2012-07-04 12:27 ` Mark Brown
2012-07-04 13:00 ` Sascha Hauer
2012-07-04 15:14 ` Alex Courbot [this message]
2012-07-04 15:24 ` Mark Brown
2012-07-05 2:36 ` Alex Courbot
2012-07-05 6:20 ` Sascha Hauer
2012-07-05 6:25 ` Alex Courbot
2012-07-05 6:47 ` Sascha Hauer
2012-07-05 7:43 ` Alex Courbot
2012-07-05 7:57 ` Thierry Reding
2012-07-05 8:12 ` Alex Courbot
2012-07-05 16:03 ` Stephen Warren
2012-07-09 5:19 ` Jingoo Han
2012-07-09 6:12 ` Alex Courbot
2012-07-05 8:02 ` Sascha Hauer
2012-07-05 10:41 ` Mark Brown
2012-07-05 10:39 ` Mark Brown
2012-07-05 10:37 ` Mark Brown
2012-07-04 20:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF45DDF.9000306@nvidia.com \
--to=acourbot@nvidia.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox