From: David Ahern <dsahern@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] perf tool: save cmdline from user in file header vs what is passed to record
Date: Thu, 05 Jul 2012 10:47:59 -0600 [thread overview]
Message-ID: <4FF5C53F.30105@gmail.com> (raw)
In-Reply-To: <CABPqkBSP9=QfU5SYfm0ys9FA6jro+az07zTMFnNAx+MMFr7+Vw@mail.gmail.com>
On 7/5/12 9:48 AM, Stephane Eranian wrote:
> On Tue, Jul 3, 2012 at 6:08 AM, David Ahern <dsahern@gmail.com> wrote:
> Yes, you need to manually add the pfm_header__set_cmdline(). That begs
I take it you meant perf_header__set_cmdline, not pfm_header...
> the question
> as to whether or not it would not be better to move this call directly into
> the parse_option() function given that it must be done BEFORE parsing actually
> takes place.That way we would be sure all present and future commands would
> be covered.
Sure, I'll move it to parse_options.
David
next prev parent reply other threads:[~2012-07-05 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 4:08 [PATCH] perf tool: save cmdline from user in file header vs what is passed to record David Ahern
2012-07-05 15:48 ` Stephane Eranian
2012-07-05 16:47 ` David Ahern [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-06 4:09 David Ahern
2012-07-06 17:17 ` Arnaldo Carvalho de Melo
2012-07-06 17:19 ` David Ahern
2012-07-30 2:53 David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5C53F.30105@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox