From: Sergei Shtylyov <sshtylyov@mvista.com>
To: gaosen <gaosen.zhang@mediatek.com>
Cc: smurf@smurf.noris.de, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Add MEDIATEK products to option driver
Date: Fri, 06 Jul 2012 16:10:04 +0400 [thread overview]
Message-ID: <4FF6D59C.7000205@mvista.com> (raw)
In-Reply-To: <CAAwpLmyKrXk=RwNv2jmaqczJyzUz7TQ808EBr1AQdopor8KGjQ@mail.gmail.com>
Hello.
On 05-07-2012 17:49, gaosen wrote:
> From bb4d2a7155393b5d1207c398c3f9644898588e8a Mon Sep 17 00:00:00 2001
> From: "gaosen.zhang" <gaosen.zhang@mediatek.com>
> Date: Thu, 5 Jul 2012 20:01:54 +0800
> Subject: [PATCH 1/1] Add MEDIATEK products to option driver
> Signed-off-by: gaosen.zhang <gaosen.zhang@mediatek.com>
Why not simply Gaosen Zhang?
> ---
> drivers/usb/serial/option.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e668a24..3d47661 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -496,6 +496,15 @@ static void option_instat_callback(struct urb *urb);
>
> /* MediaTek products */
> #define MEDIATEK_VENDOR_ID 0x0e8d
> +#define MEDIATEK_PRODUCT_DC_1COM 0x00a0
> +#define MEDIATEK_PRODUCT_DC_4COM 0x00a5
> +#define MEDIATEK_PRODUCT_DC_5COM 0x00a4
> +#define MEDIATEK_PRODUCT_7208_1COM 0x7101
> +#define MEDIATEK_PRODUCT_7208_2COM 0x7102
> +#define MEDIATEK_PRODUCT_FP_1COM 0x0003
> +#define MEDIATEK_PRODUCT_FP_2COM 0x0023
> +#define MEDIATEK_PRODUCT_FPDC_1COM 0x0043
> +#define MEDIATEK_PRODUCT_FPDC_2COM 0x0033
Shouldn't these be sorted by numeric value?
> @@ -1233,6 +1242,17 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x02, 0x01) },
> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x00, 0x00) },
> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x02, 0x01) }, /* MediaTek MT6276M modem & app port */
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_1COM, 0x0a, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x02, 0x01) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x02, 0x01) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_7208_1COM, 0x02, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_7208_2COM, 0x02, 0x02, 0x01) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FP_1COM, 0x0a, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FP_2COM, 0x0a, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FPDC_1COM, 0x0a, 0x00, 0x00) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FPDC_2COM, 0x0a, 0x00, 0x00) },
Your patch is line wrapped.
WBR, Sergei
next prev parent reply other threads:[~2012-07-06 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 13:49 Add MEDIATEK products to option driver gaosen
2012-07-06 12:10 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-06 12:35 gaosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF6D59C.7000205@mvista.com \
--to=sshtylyov@mvista.com \
--cc=gaosen.zhang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox