public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Add MEDIATEK products to option driver
@ 2012-07-05 13:49 gaosen
  2012-07-06 12:10 ` Sergei Shtylyov
  0 siblings, 1 reply; 3+ messages in thread
From: gaosen @ 2012-07-05 13:49 UTC (permalink / raw)
  To: smurf, gregkh; +Cc: linux-usb, linux-kernel

>From bb4d2a7155393b5d1207c398c3f9644898588e8a Mon Sep 17 00:00:00 2001
From: "gaosen.zhang" <gaosen.zhang@mediatek.com>
Date: Thu, 5 Jul 2012 20:01:54 +0800
Subject: [PATCH 1/1] Add MEDIATEK products to option driver


Signed-off-by: gaosen.zhang <gaosen.zhang@mediatek.com>
---
 drivers/usb/serial/option.c |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index e668a24..3d47661 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -496,6 +496,15 @@ static void option_instat_callback(struct urb *urb);

 /* MediaTek products */
 #define MEDIATEK_VENDOR_ID			0x0e8d
+#define MEDIATEK_PRODUCT_DC_1COM		0x00a0
+#define MEDIATEK_PRODUCT_DC_4COM		0x00a5
+#define MEDIATEK_PRODUCT_DC_5COM		0x00a4
+#define MEDIATEK_PRODUCT_7208_1COM		0x7101
+#define MEDIATEK_PRODUCT_7208_2COM		0x7102
+#define MEDIATEK_PRODUCT_FP_1COM		0x0003
+#define MEDIATEK_PRODUCT_FP_2COM		0x0023
+#define MEDIATEK_PRODUCT_FPDC_1COM		0x0043
+#define MEDIATEK_PRODUCT_FPDC_2COM		0x0033

 /* some devices interfaces need special handling due to a number of reasons */
 enum option_blacklist_reason {
@@ -1233,6 +1242,17 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
0x02, 0x01) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
0x00, 0x00) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
0x02, 0x01) },        /* MediaTek MT6276M modem & app port */
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_1COM, 0x0a, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x02, 0x01) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x02, 0x01) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_7208_1COM, 0x02, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_7208_2COM, 0x02, 0x02, 0x01) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_FP_1COM, 0x0a, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_FP_2COM, 0x0a, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_FPDC_1COM, 0x0a, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_FPDC_2COM, 0x0a, 0x00, 0x00) },
 	{ } /* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, option_ids);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: Add MEDIATEK products to option driver
@ 2012-07-06 12:35 gaosen
  0 siblings, 0 replies; 3+ messages in thread
From: gaosen @ 2012-07-06 12:35 UTC (permalink / raw)
  To: sshtylyov; +Cc: smurf, gregkh, linux-usb, linux-kernel

Dear sshtylyov,

        Thanks for your comments, I will change it later.

BR, Gaosen

-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov@mvista.com]
Sent: 2012年7月6日 20:10
To: Gaosen Zhang (张高森)
Cc: smurf@smurf.noris.de; gregkh@linuxfoundation.org;
linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: Add MEDIATEK products to option driver

Hello.

On 05-07-2012 17:49, gaosen wrote:

>  From bb4d2a7155393b5d1207c398c3f9644898588e8a Mon Sep 17 00:00:00
> 2001
> From: "gaosen.zhang" <gaosen.zhang@mediatek.com>
> Date: Thu, 5 Jul 2012 20:01:54 +0800
> Subject: [PATCH 1/1] Add MEDIATEK products to option driver


> Signed-off-by: gaosen.zhang <gaosen.zhang@mediatek.com>

    Why not simply Gaosen Zhang?

> ---
>   drivers/usb/serial/option.c |   20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e668a24..3d47661 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -496,6 +496,15 @@ static void option_instat_callback(struct urb
> *urb);
>
>   /* MediaTek products */
>   #define MEDIATEK_VENDOR_ID			0x0e8d
> +#define MEDIATEK_PRODUCT_DC_1COM		0x00a0
> +#define MEDIATEK_PRODUCT_DC_4COM		0x00a5
> +#define MEDIATEK_PRODUCT_DC_5COM		0x00a4
> +#define MEDIATEK_PRODUCT_7208_1COM		0x7101
> +#define MEDIATEK_PRODUCT_7208_2COM		0x7102
> +#define MEDIATEK_PRODUCT_FP_1COM		0x0003
> +#define MEDIATEK_PRODUCT_FP_2COM		0x0023
> +#define MEDIATEK_PRODUCT_FPDC_1COM		0x0043
> +#define MEDIATEK_PRODUCT_FPDC_2COM		0x0033

    Shouldn't these be sorted by numeric value?

> @@ -1233,6 +1242,17 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x02, 0x01) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x00, 0x00) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x02, 0x01) },        /* MediaTek MT6276M modem & app port */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_1COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x02, 0x01) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x02, 0x01) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_7208_1COM, 0x02, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_7208_2COM, 0x02, 0x02, 0x01) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FP_1COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FP_2COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FPDC_1COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FPDC_2COM, 0x0a, 0x00, 0x00) },

    Your patch is line wrapped.

WBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-06 12:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-05 13:49 Add MEDIATEK products to option driver gaosen
2012-07-06 12:10 ` Sergei Shtylyov
  -- strict thread matches above, loose matches on Subject: below --
2012-07-06 12:35 gaosen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox