From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755561Ab2GFMks (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Jul 2012 08:40:48 -0400
Received: from mail-ob0-f174.google.com ([209.85.214.174]:39565 "EHLO
	mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751496Ab2GFMkq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Jul 2012 08:40:46 -0400
Message-ID: <4FF6DCCA.2080509@gmail.com>
Date: Fri, 06 Jul 2012 07:40:42 -0500
From: Rob Herring <robherring2@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
MIME-Version: 1.0
To: jgq516@gmail.com
CC: linux@arm.linux.org.uk, tony@atomide.com, plagnioj@jcrosoft.com,
        nicolas.ferre@atmel.com, arnd@arndb.de, swarren@nvidia.com,
        olof@lixom.net, ldewangan@nvidia.com, hdoyu@nvidia.com,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
References: <1341571127-14461-1-git-send-email-jgq516@gmail.com>
In-Reply-To: <1341571127-14461-1-git-send-email-jgq516@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/06/2012 05:38 AM, jgq516@gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
> 
> Since more and more arm chips support device tree, it'd be better add PROC_DEVICETREE
> in arch/arm/Kconfig to avoid duplicate code.

I think this should remain user choice. If its going to be selected,
then you might as well just remove the option altogether. Perhaps just
make the option default to yes.

Rob

> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
>  arch/arm/Kconfig                   |    1 +
>  arch/arm/configs/at91_dt_defconfig |    1 -
>  arch/arm/configs/tegra_defconfig   |    1 -
>  arch/arm/plat-omap/Kconfig         |    1 -
>  4 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a91009c..f68896e 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1864,6 +1864,7 @@ config USE_OF
>  	select OF
>  	select OF_EARLY_FLATTREE
>  	select IRQ_DOMAIN
> +	select PROC_DEVICETREE if PROC_FS
>  	help
>  	  Include support for flattened device tree machine descriptions.
>  
> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
> index 67bc571..b856cb6 100644
> --- a/arch/arm/configs/at91_dt_defconfig
> +++ b/arch/arm/configs/at91_dt_defconfig
> @@ -64,7 +64,6 @@ CONFIG_MTD_NAND=y
>  CONFIG_MTD_NAND_ATMEL=y
>  CONFIG_MTD_UBI=y
>  CONFIG_MTD_UBI_GLUEBI=y
> -CONFIG_PROC_DEVICETREE=y
>  CONFIG_BLK_DEV_LOOP=y
>  CONFIG_BLK_DEV_RAM=y
>  CONFIG_BLK_DEV_RAM_COUNT=4
> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
> index 1198dd6..43e7b65 100644
> --- a/arch/arm/configs/tegra_defconfig
> +++ b/arch/arm/configs/tegra_defconfig
> @@ -72,7 +72,6 @@ CONFIG_IPV6_TUNNEL=y
>  CONFIG_IPV6_MULTIPLE_TABLES=y
>  # CONFIG_WIRELESS is not set
>  # CONFIG_FIRMWARE_IN_KERNEL is not set
> -CONFIG_PROC_DEVICETREE=y
>  CONFIG_BLK_DEV_LOOP=y
>  CONFIG_AD525X_DPOT=y
>  CONFIG_AD525X_DPOT_I2C=y
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ad95c7a..4e2cb17 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -27,7 +27,6 @@ config ARCH_OMAP2PLUS
>  	select GENERIC_IRQ_CHIP
>  	select OMAP_DM_TIMER
>  	select USE_OF
> -	select PROC_DEVICETREE if PROC_FS
>  	help
>  	  "Systems based on OMAP2, OMAP3 or OMAP4"
>  
>