linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: martin-eric.racine@iki.fi
Cc: "Jean-François Moine" <moinejf@free.fr>,
	677533@bugs.debian.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: video: USB webcam fails since kernel 3.2
Date: Mon, 09 Jul 2012 15:12:57 +0200	[thread overview]
Message-ID: <4FFAD8D9.8070203@redhat.com> (raw)
In-Reply-To: <CAPZXPQd026xfKrAU0D7CLQGbdAs8U01u5vsHp+5-wbVofAwdqQ@mail.gmail.com>

Hi,

On 07/09/2012 01:33 PM, Martin-Éric Racine wrote:

<snip>

>> Hmm, this is then likely caused by the new isoc bandwidth negotiation code
>> in 3.2, unfortunately the vc032x driver is one of the few gspca drivers
>> for which I don't have a cam to test with. Can you try to build your own
>> kernel from source?
>>
>> Boot into your own kernel, and verify the regression is still there,
>> then edit drivers/media/video/gspca/gspca.c and go to the which_bandwidth
>> function, and at the beginning of this function add the following line:
>>
>> return 2000 * 2000 * 120;
>>
>> Then rebuild and re-install the kernel and try again.
>>
>> If that helps, remove the added
>> return 2000 * 2000 * 120;
>> line, and also remove the following lines from which_bandwidth:
>>
>>          /* if the image is compressed, estimate its mean size */
>>          if (!gspca_dev->cam.needs_full_bandwidth &&
>>              bandwidth < gspca_dev->cam.cam_mode[i].width *
>>                                  gspca_dev->cam.cam_mode[i].height)
>>                  bandwidth = bandwidth * 3 / 8;  /* 0.375 */
>>
>> And try again if things still work this way.
>>
>> Once you've tested this I can try to write a fix for this.
>
> Hans,
>
> Thank you for your reply.
>
> Just to eliminate the possibility of mistakes on my part while trying
> to perform the above changes, could you send me a patch against Linux
> 3.2.21 that I could apply as-is, before building myself a test kernel
> package?

Erm, that is quite a bit of work from my side for something which you
can easily do yourself, edit gspca.c, search for which_bandwidth
and then under the following lines:
         u32 bandwidth;
         int i;

Add a line like this:
	return 2000 * 2000 * 120;

Regards,

Hans

  reply	other threads:[~2012-07-09 13:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120614162609.4613.22122.reportbug@henna.lan>
     [not found] ` <20120614215359.GF3537@burratino>
     [not found]   ` <CAPZXPQd9gNCxn7xGyqj_xymPaF5OxvRtxRFkt+SsLs942te4og@mail.gmail.com>
     [not found]     ` <20120616044137.GB4076@burratino>
2012-06-17 11:23       ` video: USB webcam fails since kernel 3.2 Martin-Éric Racine
2012-06-17 17:11         ` Jonathan Nieder
2012-06-17 17:12           ` Jonathan Nieder
2012-07-08 13:01         ` Martin-Éric Racine
2012-07-08 17:58           ` Hans de Goede
2012-07-09 11:33             ` Martin-Éric Racine
2012-07-09 13:12               ` Hans de Goede [this message]
2012-07-09 20:39                 ` Jonathan Nieder
2012-07-10 12:56                   ` Martin-Éric Racine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFAD8D9.8070203@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=677533@bugs.debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martin-eric.racine@iki.fi \
    --cc=moinejf@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).