From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919Ab2GIU4z (ORCPT ); Mon, 9 Jul 2012 16:56:55 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:51001 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825Ab2GIU4y (ORCPT ); Mon, 9 Jul 2012 16:56:54 -0400 Message-ID: <4FFB4591.2050601@linaro.org> Date: Mon, 09 Jul 2012 22:56:49 +0200 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Dmitry Torokhov CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de Subject: Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping References: <1341493572-29735-1-git-send-email-lee.jones@linaro.org> <4FF6994B.9040801@linaro.org> <20120706173957.GA10202@core.coreip.homeip.net> <4FFB288D.4080606@linaro.org> <20120709201422.GA12242@core.coreip.homeip.net> <4FFB40A4.5060505@linaro.org> <20120709204620.GA12692@core.coreip.homeip.net> In-Reply-To: <20120709204620.GA12692@core.coreip.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/12 22:46, Dmitry Torokhov wrote: > On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: >> From: Lee Jones >> Date: Tue, 26 Jun 2012 10:46:50 +0100 >> Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping >> >> Before we can use any domain allocated IRQ, we need to first create a >> map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). >> We do this with a helper function provided by the AB8500 IRQ domain >> controller called ab8500_irq_get_virq(). We need to do this for both >> IRQs which the Power-On-Key driver uses; one for button press, the other >> for button depress. >> >> Signed-off-by: Lee Jones >> --- >> drivers/input/misc/ab8500-ponkey.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c >> index 5ceb23e..8d24189 100644 >> --- a/drivers/input/misc/ab8500-ponkey.c >> +++ b/drivers/input/misc/ab8500-ponkey.c >> @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) >> >> ponkey->idev = input; >> ponkey->ab8500 = ab8500; >> - ponkey->irq_dbf = irq_dbf; >> - ponkey->irq_dbr = irq_dbr; >> + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbf); >> + ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, ponkey->irq_dbr); > ^^^^^^^^^^^^^^^ > > These are zeroes now. Man, you are killing me... I've been traveling all day and my brain is dead. Hopefully you have a sense of humor. :) Give me two mins. -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog