From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937Ab2GJG1R (ORCPT ); Tue, 10 Jul 2012 02:27:17 -0400 Received: from na3sys009aog131.obsmtp.com ([74.125.149.247]:45985 "EHLO na3sys009aog131.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752543Ab2GJG1P (ORCPT ); Tue, 10 Jul 2012 02:27:15 -0400 Message-ID: <4FFBCB39.1010809@ti.com> Date: Tue, 10 Jul 2012 11:57:05 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110805 Thunderbird/3.1.12 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk, gregkh@linuxfoundation.org, b-cousson@ti.com, tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, balbi@ti.com, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, hvaibhav@ti.com Subject: Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data References: <1340884267-28908-1-git-send-email-kishon@ti.com> <1340884267-28908-11-git-send-email-kishon@ti.com> In-Reply-To: <1340884267-28908-11-git-send-email-kishon@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: > Add usb otg data node in omap4/omap3 device tree file. Also update > the node with board specific setting in omapx-.dts file. > > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm/boot/dts/omap3-beagle.dts | 6 ++++++ > arch/arm/boot/dts/omap3-evm.dts | 6 ++++++ > arch/arm/boot/dts/omap3.dtsi | 8 ++++++++ > arch/arm/boot/dts/omap4-panda.dts | 6 ++++++ > arch/arm/boot/dts/omap4-sdp.dts | 6 ++++++ > arch/arm/boot/dts/omap4.dtsi | 8 ++++++++ > 6 files changed, 40 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts > index 5b4506c..f3d7076 100644 > --- a/arch/arm/boot/dts/omap3-beagle.dts > +++ b/arch/arm/boot/dts/omap3-beagle.dts > @@ -67,3 +67,9 @@ > &mmc3 { > status = "disable"; > }; > + > +&usb_otg_hs { > + interface_type =<0>; > + mode =<3>; > + power =<50>; > +}; > diff --git a/arch/arm/boot/dts/omap3-evm.dts b/arch/arm/boot/dts/omap3-evm.dts > index 2eee16e..8963b3d 100644 > --- a/arch/arm/boot/dts/omap3-evm.dts > +++ b/arch/arm/boot/dts/omap3-evm.dts > @@ -18,3 +18,9 @@ > reg =<0x80000000 0x10000000>; /* 256 MB */ > }; > }; > + > +&usb_otg_hs { > + interface_type =<0>; > + mode =<3>; > + power =<50>; > +}; > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index 99474fa..2f565d6 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -215,5 +215,13 @@ > compatible = "ti,omap3-hsmmc"; > ti,hwmods = "mmc3"; > }; > + > + usb_otg_hs: usb_otg_hs@4a0ab000 { > + compatible = "ti,musb-omap2430"; this compatible doesn't seem right in omap3.dtsi. Same with the below entry in omap4.dtsi. See other IP blocks which are reused across OMAP2/3/4 on how the compatible for those are handled. > + ti,hwmods = "usb_otg_hs"; > + multipoint =<1>; > + num_eps =<16>; > + ram_bits =<12>; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts > index 1efe0c5..0825fa7 100644 > --- a/arch/arm/boot/dts/omap4-panda.dts > +++ b/arch/arm/boot/dts/omap4-panda.dts > @@ -89,3 +89,9 @@ > ti,non-removable; > bus-width =<4>; > }; > + > +&usb_otg_hs { > + interface_type =<1>; > + mode =<3>; > + power =<50>; > +}; > diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts > index d08c4d1..5244d51 100644 > --- a/arch/arm/boot/dts/omap4-sdp.dts > +++ b/arch/arm/boot/dts/omap4-sdp.dts > @@ -158,3 +158,9 @@ > bus-width =<4>; > ti,non-removable; > }; > + > +&usb_otg_hs { > + interface_type =<1>; > + mode =<3>; > + power =<50>; > +}; > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 4d2dcc1..bc7b3c3 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -285,5 +285,13 @@ > <0x4a002300 0x1>; > }; > }; > + > + usb_otg_hs: usb_otg_hs@4a0ab000 { > + compatible = "ti,musb-omap2430"; > + ti,hwmods = "usb_otg_hs"; > + multipoint =<1>; > + num_eps =<16>; > + ram_bits =<12>; > + }; > }; > };