From: Rob Herring <robherring2@gmail.com>
To: "Bityutskiy, Artem" <artem.bityutskiy@intel.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: mtd: nuke useless const qualifier
Date: Tue, 10 Jul 2012 10:35:17 -0500 [thread overview]
Message-ID: <4FFC4BB5.7040604@gmail.com> (raw)
In-Reply-To: <1341927604.2963.101.camel@sauron>
On 07/10/2012 08:35 AM, Bityutskiy, Artem wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>
> This patch does the following:
> -const int of_get_nand_ecc_mode(struct device_node *np)
> +int of_get_nand_ecc_mode(struct device_node *np)
>
> because:
> 1. it is probably just a typo?
> 2. it causes warnings like this when people assing the returned
> value to an 'int' variable:
> include/linux/of_mtd.h:14:18: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
>
> Remove also the unnecessary "extern" qualifier to be consistent with other
> declarations in this file.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> ---
Applied. Next time please don't PGP sign patches.
Rob
> drivers/of/of_mtd.c | 2 +-
> include/linux/of_mtd.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/of_mtd.c b/drivers/of/of_mtd.c
> index e7cad62..a27ec94 100644
> --- a/drivers/of/of_mtd.c
> +++ b/drivers/of/of_mtd.c
> @@ -32,7 +32,7 @@ static const char *nand_ecc_modes[] = {
> * The function gets ecc mode string from property 'nand-ecc-mode',
> * and return its index in nand_ecc_modes table, or errno in error case.
> */
> -const int of_get_nand_ecc_mode(struct device_node *np)
> +int of_get_nand_ecc_mode(struct device_node *np)
> {
> const char *pm;
> int err, i;
> diff --git a/include/linux/of_mtd.h b/include/linux/of_mtd.h
> index bae1b60..ed7f267 100644
> --- a/include/linux/of_mtd.h
> +++ b/include/linux/of_mtd.h
> @@ -11,7 +11,7 @@
>
> #ifdef CONFIG_OF_MTD
> #include <linux/of.h>
> -extern const int of_get_nand_ecc_mode(struct device_node *np);
> +int of_get_nand_ecc_mode(struct device_node *np);
> int of_get_nand_bus_width(struct device_node *np);
> bool of_get_nand_on_flash_bbt(struct device_node *np);
> #endif
>
>
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
next prev parent reply other threads:[~2012-07-10 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 13:35 [PATCH] of: mtd: nuke useless const qualifier Bityutskiy, Artem
2012-07-10 15:35 ` Rob Herring [this message]
2012-07-11 5:49 ` Bityutskiy, Artem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC4BB5.7040604@gmail.com \
--to=robherring2@gmail.com \
--cc=arnd.bergmann@linaro.org \
--cc=artem.bityutskiy@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox